Bug 13799 - Backup fails
Summary: Backup fails
Status: ASSIGNED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - Major Usability
Assignee: Adolf Belka
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-09 13:47 UTC by Bernhard Bitsch
Modified: 2024-12-20 10:05 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Bitsch 2024-12-09 13:47:05 UTC
In a community post appeared the problem, that after new install the backup config of a addon could not be restored.
Looking into the sources of backup.cgi, backupctrl and backup.pl I found the issue.
In backup.pl the restore is done by
- if a backup file is in /tmp, move it to /var/ipfire/backup/addons/backup
- extract the backup file in /var/....

The test of existence in backup.pl ( line 288) is done by
if [ -d "/tmp/${name}.ipf" ]; then
which should be
if [ -f "/tmp/${name}.ipf" ]; then
Comment 1 Michael Tremer 2024-12-09 14:16:43 UTC
Cool, are you able to send a patch for this change?
Comment 4 Adolf Belka 2024-12-19 09:10:13 UTC
Hi @Bernhard,

Will you be supplying a patch for this or would it help if I picked it up?
Comment 5 Bernhard Bitsch 2024-12-19 12:10:46 UTC
(In reply to Adolf Belka from comment #4)
> Hi @Bernhard,
> 
> Will you be supplying a patch for this or would it help if I picked it up?

Hi @Adolf,
it would help, if you pick it up.
Thx in advance.