Bug 13783 - usability un readable
Summary: usability un readable
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: x86_64 Linux
: - Unknown - Minor Usability
Assignee: Assigned to nobody - feel free to grab it and work on it
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-03 20:23 UTC by Shaun HVAC
Modified: 2025-01-23 10:53 UTC (History)
2 users (show)

See Also:


Attachments
Example of page enteries (19.41 KB, image/png)
2024-10-03 20:23 UTC, Shaun HVAC
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun HVAC 2024-10-03 20:23:07 UTC
Created attachment 1612 [details]
Example of page enteries

problem
DNS forward configuration 
usability

Entries are unreadable
white on white text.
Comment 1 Waynie 2024-10-17 09:26:12 UTC

DNS forward configuration - color of entries there:

In /srv/web/ipfire/cgi-bin/

approximately in line 328 replace ‚white‘ with ‚black‘.

That should be all.
Comment 2 Waynie 2024-10-17 09:35:05 UTC
DNS forward configuration - here readability

Approximately in line 328 replace 'black' with 'white:



- $col="bgcolor='${Header::colourred}' style='color: black'"; }
+ $col="bgcolor='${Header::colourred}' style='color: white'"; }


That should do the job. :-)
Comment 3 Adolf Belka 2024-10-21 19:17:54 UTC
It is the text colour that needs to be changed, not the background colour.
Comment 4 Waynie 2024-10-22 08:38:23 UTC
You're right, Adolf!

style='color: ...' sets the color of the text.
Comment 5 Adolf Belka 2024-10-22 14:52:12 UTC
(In reply to Waynie from comment #4)
> You're right, Adolf!
> 
> style='color: ...' sets the color of the text.

Sorry, my mistake. You are right. I saw the bgcolor word and didn't look through the whole line closely enough.

However this also shows the need for clearing up and standardising of the code as other cgi pages don't specify the text colour in the same way and so each page needs to be looked at individually to fix things so if an update is required it can't be done to any central code and then apply to all pages as it should do.

Feel free to submit a patch to the dev mailing list with the change.

https://www.ipfire.org/docs/devel/submit-patches
Comment 6 Adolf Belka 2024-10-22 14:53:54 UTC
IPFire-2.x component should always be --. A named component is only used for IPFire-3.x
Comment 7 Adolf Belka 2024-12-13 09:55:40 UTC
The patch has been merged into next and will be in CU191

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=de8ed87d05887907740bef72180b6e8f63d01416
Comment 9 Adolf Belka 2025-01-04 11:18:46 UTC
The testing install of CU191 on my vm testbed shows the problem as fixed.

Would be good if the original bug poster can also confirm that they consider it solved.