Bug 13195 - CU177 Testing - Rebooting ends with a fail message for remount root readonly
Summary: CU177 Testing - Rebooting ends with a fail message for remount root readonly
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Michael Tremer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-27 20:06 UTC by Adolf Belka
Modified: 2023-08-07 11:18 UTC (History)
1 user (show)

See Also:

Attachments
failo message for remount root readonly line at reboot (42.12 KB, image/png)
2023-07-27 20:06 UTC, Adolf Belka 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adolf Belka 2023-07-27 20:06:40 UTC 
Created attachment 1227 [details]
failo message for remount root readonly line at reboot

After updating a CU176 vm to CU177 and rebooting, just before the reboot message there is a line about remount root readonly and this comes up with a fail result.

Repeated on another CU177 system and the same message occurs. See screenshot attachment
Comment 1 Adolf Belka 2023-07-27 20:08:28 UTC 
Forgot to mention repeating the reboot comes up with the same fail message. However the reboot itself seems to occur okay in that after the reboot IPFire is running as would be expected.
Comment 2 Michael Tremer 2023-07-28 10:05:31 UTC 
Thank you for this bug report. I can confirm this and this is a really big problem, because it could potentially cause filesystem corruption if we cannot properly remount it as read-only.

I tried to debug this myself and could not find anything, so I opened a ticket upstream:

> https://github.com/util-linux/util-linux/issues/2395

I hope we can resolve this quickly. Otherwise we might have to revert the update of util-linux.
Comment 3 Michael Tremer 2023-07-28 17:21:34 UTC 
So, as we just found out, the -f switch is short for --fake. It means that the binary in the end won't run the syscall, or in essence doesn't do anything at all.

So we are removing it:

> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=0bb82a95dd383912bde857db9a7d702604e582f6
Comment 4 Adolf Belka 2023-07-29 07:31:28 UTC 
Just tried the latest nightly build dated 2023-07-28 19:48

The remount read only fail message is no longer shown.

Fix confirmed to work.