Bug 13164 - PPP: Update Package
Summary: PPP: Update Package
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all All
: - Unknown - - Unknown -
Assignee: Adolf Belka
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-29 17:15 UTC by A G
Modified: 2023-09-28 10:48 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description A G 2023-06-29 17:15:11 UTC
It appears that IPFire is shipping with PPP 2.4.9, although PPP 2.5.0 was released in April. I'm unsure if it has skipped intentionally.

Here's the changelog from their Github page:

What's new in ppp-2.5.0.
************************

The 2.5.0 release is a major release of pppd which contains breaking 
changes for third-party plugins, a complete revamp of the build-system
and that allows for flexibility of configuring features as needed.

In Summary:
* Support for PEAP authentication by Eivind Næss and Rustam Kovhaev
* Support for loading PKCS12 certificate envelopes 
* Adoption of GNU Autoconf / Automake build environment, by Eivind Næss
  and others.
* Support for pkgconfig tool has been added by Eivind Næss.
* Bunch of fixes and cleanup to PPPoE and IPv6 support by Pali Rohár.
* Major revision to PPPD's Plugin API by Eivind Næss.
  - Defines in which describes what features was included in pppd
  - Functions now prefixed with explicit ppp_* to indicate that
    pppd functions being called.
  - Header files were renamed to better align with their features,
    and now use proper include guards
  - A pppdconf.h file is supplied to allow third-party modules to use
    the same feature defines pppd was compiled with.
  - No extern declarations of internal variable names of pppd, 
    continued use of these extern variables are considered 
    unstable.
* Lots of internal fixes and cleanups for Radius and PPPoE by Jaco Kroon
* Dropped IPX support, as Linux has dropped support in version 5.15
  for this protocol.
* Many more fixes and cleanups.
* Pppd is no longer installed setuid-root.
* New pppd options:
  - ipv6cp-noremote, ipv6cp-nosend, ipv6cp-use-remotenumber,
    ipv6-up-script, ipv6-down-script
  - -v, show-options
  - usepeerwins, ipcp-no-address, ipcp-no-addresses, nosendip
* On Linux, any baud rate can be set on a serial port provided the
  kernel serial driver supports that.
Comment 1 Adolf Belka 2023-06-29 18:42:07 UTC
No not skipped intentionally.

There are 686 software packages used in IPFire and that doesn't include the code for the WUI or other supporting stuff. There are less than 10 volunteers supporting the work on IPFire and scanning through everything to see what has an update takes time.

I would also say that when the change log says that this is a major release with breaking changes, I would want to be careful with the update. As I don't use ppp with IPFire, I would not be able to test the change.

It is also not as simple as it might at first sound as there are 6 patches to the source code with version 2.4.9 plus two further modifications to the source code.

So changing to a new version requires checking if those patches are still required and if so updating them.

I can certainly do an update to the ppp package but if this is accepted into Core Update 177 then it would be good if you were able to evaluate the change in the Testing Release when it comes.

Would you be willing to support that?
Comment 2 A G 2023-06-29 18:54:26 UTC
Yes, I'm more than willing to test PPP 2.5.0 on Core Update 177 if/when it is released to the testing channel.
Comment 5 Adolf Belka 2023-08-18 14:02:59 UTC
The patch has been moved to CU179 due to the CU178 release with hardware vulnerability fixes.
Comment 6 Adolf Belka 2023-08-18 14:11:24 UTC
Update needed as the directory for the pid files is being set as /usr/var/run, when it should be /var/run

Will update the patch submission.
Comment 7 Adolf Belka 2023-08-18 19:59:56 UTC
Patch submitted to Dev mailing list and patchwork to fix the directory for pid files to /var/run

https://lists.ipfire.org/pipermail/development/2023-August/016337.html
https://patchwork.ipfire.org/project/ipfire/patch/20230818184645.3934968-1-adolf.belka@ipfire.org/
Comment 9 Adolf Belka 2023-08-25 12:02:16 UTC
A problem was reported with the ppp update in Core Update 179 Testing

https://lists.ipfire.org/pipermail/development/2023-August/016349.html

It was found that this issue has been raised in the ppp github issues page and a fix committed. This will be applied in version 2.5.1 but until then an IPFire patch has been submitted that applies the ppp commit patch.

https://lists.ipfire.org/pipermail/development/2023-August/016352.html
https://patchwork.ipfire.org/project/ipfire/patch/20230824083726.3385938-1-adolf.belka@ipfire.org/

This patch has been accepted and has been merged into Core Update 179 Testing.

Updating to the latest Core Update 179 Testing version will allow this to be tested and confirmed.
Comment 10 Adolf Belka 2023-09-04 12:05:24 UTC
After the last patch the Bug reporter has confirmed that ppp-2.5.0 is working correctly.

Copied from the forum post

====================================================

Hello everyone,

I hope you’re all doing well.

I’ve updated and restarted my IPFire firewall to the new testing release, and I can confirm that the bug observed by @pmueller and also present in my logs (though I initially did not see it) has been resolved.
Log Post-Update:

18:23:21  pppd[15842]:     Modem hangup
18:23:21  pppd[15842]:     Connect time 6894.4 minutes.
18:23:21  pppd[15842]:     Sent 760791880 bytes, received 3009721987 bytes.
18:23:21  pppd[15842]:     Connection terminated.
18:24:08  pppd[2467]:     Plugin pppoe.so loaded.
18:24:08  pppd[2467]:     PPPoE plugin from pppd 2.5.0
18:24:08  pppd[2467]:     pppd 2.5.0 started by root, uid 0
18:24:13  pppd[2467]:     PPP session is 24
18:24:13  pppd[2467]:     Connected to AA:BB:CC:DD:EE:FF via interface red0
18:24:13  pppd[2467]:     Using interface ppp0
18:24:13  pppd[2467]:     Connect: ppp0 <--> red0
18:24:13  pppd[2467]:     CHAP authentication succeeded
18:24:13  pppd[2467]:     CHAP authentication succeeded
18:24:13  pppd[2467]:     peer from calling number AA:BB:CC:DD:EE:FF authorized
18:24:13  pppd[2467]:     local IP address 192.168.XX.XX
18:24:13  pppd[2467]:     remote IP address 10.XX.XX.XX
18:24:13  pppd[2467]:     primary DNS address XXX.XX.X.XXX
18:24:13  pppd[2467]:     secondary DNS address XXX.XX.X.XXX

Observations:

    The previous issue with the message 'pppd uses obsolete (PF_INET,SOCK_PACKET) is now resolved.
    The connection was terminated and re-established successfully without any issues.

In summary, the updated release appears stable in my setup and addresses the previously noted issues.

Thanks to @AdolfBelka and everyone involved.

Best regards,
A G

====================================================

See the forum thread
https://community.ipfire.org/t/core-update-179-testing-evaluating-ppp-2-5-0/10227
for further details