Bug 12979 - Ipblocklist.cgi Log dropped packets Check box stay checked
Summary: Ipblocklist.cgi Log dropped packets Check box stay checked
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: Will only affect a few users Minor Usability
Assignee: Stefan Schantl
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-02 16:24 UTC by Phil SCAR
Modified: 2023-04-18 16:37 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Phil SCAR 2022-11-02 16:24:30 UTC 
When unchecking it, the logs are well stopped after save and reload fireqall rules
But the box remains checked on the page.

write LOGGING=off in /var/ipfire/ipblocklist/settings could resolve the problem
Comment 2 Matthias Fischer 2022-11-19 19:15:06 UTC 
Confirmed.

Furthermore, once decativated, the default entry 'LOGGING=ON' is deleted and it can't be activated again. Even if the option is checked, 'LOGGING=ON' doesn't show up in the settings file.

You have to add this line manually in the settings file and reload firewall rules, otherwise logging stays off.
Comment 3 Phil SCAR 2023-03-01 15:45:24 UTC 
Message when starting the firewall after unchecking "Log dropped packets"

Setting up firewall
Use of uninitialized value $blocklistsettings{"LOGGING"} in string eq at /usr/lib/firewall/rules.pl line 764.
Use of uninitialized value $blocklistsettings{"LOGGING"} in string eq at /usr/lib/firewall/rules.pl line 764.
Use of uninitialized value $blocklistsettings{"LOGGING"} in string eq at /usr/lib/firewall/rules.pl line 764.
Use of uninitialized value $blocklistsettings{"LOGGING"} in string eq at /usr/lib/firewall/rules.pl line 764.
Use of uninitialized value $blocklistsettings{"LOGGING"} in string eq at /usr/lib/firewall/rules.pl line 764.
Comment 4 Stefan Schantl 2023-03-07 12:18:28 UTC 
Fix has been sent to the development mailing list:

https://patchwork.ipfire.org/project/ipfire/patch/20230307121735.6485-2-stefan.schantl@ipfire.org/
Comment 7 Adolf Belka 2023-03-21 22:17:47 UTC 
Tested this with CU174 Testing on my vm testbed and confirmed that the log checkbox can be changed and stays as changed after the page has been saved.

This verifies the bug fix.