Bug 12933 - Addon cpufreq: is it a "Service" ?
Summary: Addon cpufreq: is it a "Service" ?
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Adolf Belka
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-18 15:25 UTC by Charles Brown
Modified: 2022-10-20 13:23 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Brown 2022-09-18 15:25:42 UTC
After updating to C170, Addon "cpufreq" shows as a stopped service on the services.cgi page.  See discussion @ 

https://community.ipfire.org/t/cu-170-testing-list-of-services-is-not-complete-in-the-webgui-status-services/8413/24
and
https://lists.ipfire.org/pipermail/development/2022-September/014424.html
Comment 1 Adolf Belka 2022-09-19 14:27:30 UTC
I have done some more general searching and reading through the cpufrequtils initscript and seeing what is done with other OS's.


cpufrequtils is a set of tools to manage info about the cpu.

The initscript in IPFire is loading the required modules for cpufrequtils. These are not loaded as standard on IPFire and after installing the cpufrequtils addon the initscript is run to load the required modules, which will be tailored to the cpu that is present on the system.

The module loading script is run as an initscxript as it needs to be run after evry reboot to reload the required modules.

This is therefore not a daemon process but just a set of tools that only get run by the user from the command line.


I will create a patch to remove the service status from cpufrequtils. It should not end up being shown in the addons services table.
Comment 2 Adolf Belka 2022-09-19 14:54:30 UTC
Patch submitted to dev mailing list and to patchwork.

https://patchwork.ipfire.org/project/ipfire/patch/20220919145129.6714-1-adolf.belka@ipfire.org/
Comment 3 Adolf Belka 2022-09-21 10:52:04 UTC
v2 patch submitted to replace the use of the $SERVICES variable in the install initscript section of the lfs

https://patchwork.ipfire.org/project/ipfire/patch/20220921103719.3810-1-adolf.belka@ipfire.org/
Comment 4 Adolf Belka 2022-09-24 12:36:24 UTC
Patch has been committed into next which will become Core Update 171

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=7bb62b122541633c0e79538120b1175faaa521bb
Comment 6 Adolf Belka 2022-10-06 12:01:20 UTC
Confirmed with CU171 Testing on my vm testbed that cpufreq no longer gets shown in the addon services table on services.cgi
Comment 7 Charles Brown 2022-10-06 12:49:57 UTC
On my fresh install of c171 (master/ca4de263 x86_64) and restored from backup, 
I am still seeing cpufreq in the addon services table on services.cgi.  Perhaps the fix didn't make the trip from next to master
-cab
Comment 8 Adolf Belka 2022-10-06 13:06:12 UTC
(In reply to Charles Brown from comment #7)
> On my fresh install of c171 (master/ca4de263 x86_64) and restored from
> backup, 
> I am still seeing cpufreq in the addon services table on services.cgi. 
> Perhaps the fix didn't make the trip from next to master
> -cab

My CU170 updated to
IPFire 2.27 (x86_64) - Core-Update 171 Development Build: master/ca4de263

and that is the same version as you used and for me I don't see cpufreq in the addons services table.

I will retry with a CU170 clone with cpufreq installed. Do a backup and then do a full install with CU171 Testing and then install cpufreq and then restore the backup and see what is on the addons services table at each stage.

Am moving this back to ON_QA until your issue is resolved.
Comment 9 Charles Brown 2022-10-06 13:37:41 UTC
(In reply to Adolf Belka from comment #8)
> (In reply to Charles Brown from comment #7)
> > On my fresh install of c171 (master/ca4de263 x86_64) and restored from
> > backup, 
> > I am still seeing cpufreq in the addon services table on services.cgi. 
> > Perhaps the fix didn't make the trip from next to master
> > -cab
> 
> My CU170 updated to
> IPFire 2.27 (x86_64) - Core-Update 171 Development Build: master/ca4de263
> 
> and that is the same version as you used and for me I don't see cpufreq in
> the addons services table.
> 
> I will retry with a CU170 clone with cpufreq installed. Do a backup and then
> do a full install with CU171 Testing and then install cpufreq and then
> restore the backup and see what is on the addons services table at each
> stage.
> 
> Am moving this back to ON_QA until your issue is resolved.

After punch "mine" back to 170 and doing an upgrade that cleared the issue.  Perhaps there is a problem with the installer (for fresh install) is not working as well as the upgrade processing
-cab
Comment 10 Adolf Belka 2022-10-06 14:18:36 UTC
I have now created a CU170 clone and installed cpufreq on it. cpufreq shows up in the addons services table.

Then I have created a backup of the whole IPFire. There is no backup option for cpufreq.

Then I have done a fresh install of CU171 Testing. Then I have installed cpufreq and checked the services.cgi page. cpufreq is not showing in the addons services table.

Then I have restored my backup. Checked the addons services table. No cpufreq.

Rebooted and checked services.cgi again and still no cpufreq in the addons services table.

I have not been able to reproduce the issue you experienced.

Can you please retry doing a fresh install of CU171 Testing and see if the issue with cpufreq showing up in the addons services table occurs again or not.
Comment 11 Charles Brown 2022-10-06 15:38:06 UTC
(In reply to Adolf Belka from comment #10)
> I have now created a CU170 clone and installed cpufreq on it. cpufreq shows
> up in the addons services table.
> 
> Then I have created a backup of the whole IPFire. There is no backup option
> for cpufreq.
> 
> Then I have done a fresh install of CU171 Testing. Then I have installed
> cpufreq and checked the services.cgi page. cpufreq is not showing in the
> addons services table.
> 
> Then I have restored my backup. Checked the addons services table. No
> cpufreq.
> 
> Rebooted and checked services.cgi again and still no cpufreq in the addons
> services table.
> 
> I have not been able to reproduce the issue you experienced.
> 
> Can you please retry doing a fresh install of CU171 Testing and see if the
> issue with cpufreq showing up in the addons services table occurs again or
> not.

Indeed, the subsequent fresh install did work as desired.  Sorry for raising the false alarm.
-cab
Comment 12 Adolf Belka 2022-10-06 19:55:09 UTC
(In reply to Charles Brown from comment #11)
> 
> Indeed, the subsequent fresh install did work as desired.  Sorry for raising
> the false alarm.
> -cab

Don't worry about it. I would rather that things are raised now and investigated than left and turn out to be a problem when a Core Update is released.

I have also had from time to time odd glitches that I raised a bug on that then turned out not to occur when repeated.

Marking this bug as VERIFIED.