Bug 12932 - Core Update 170 - ISO backup fails to work
Summary: Core Update 170 - ISO backup fails to work
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - Major Usability
Assignee: Adolf Belka
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-17 21:24 UTC by Adolf Belka
Modified: 2022-10-20 13:23 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adolf Belka 2022-09-17 21:24:57 UTC 
When a backup to create an ISO is run with CU170 it fails to complete.

This is due to a change in the name of the ISO file stored on the download site.

The file name for the iso was modified by commit
https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=fbd0608c2cb5372fff7857065ec7e605b1bf9cf7
to make it aligned with the image file name.

This ISO filename is also used by the IPFire bacxkup process when creating an iso backup file.

The iso file name in the backup program needs to be adjusted yo be in line with the modified template specified by the above commit.
Comment 1 Matthias Fischer 2022-09-17 21:41:52 UTC 
Suggested fix (seems to works here, please test):

diff --git a/src/scripts/backupiso b/src/scripts/backupiso
index ef017e3be..2a016e067 100644
--- a/src/scripts/backupiso
+++ b/src/scripts/backupiso
@@ -35,7 +35,7 @@ case "${arch}" in
 esac

 URL="https://downloads.ipfire.org/releases/ipfire-2.x/$IPFVER-core$COREVER/"
-ISO="ipfire-$IPFVER.$arch-full-core$COREVER.iso"
+ISO="ipfire-$IPFVER-core$COREVER-$arch.iso"

 makeiso() {
        local dir="${1}"
Comment 2 Adolf Belka 2022-09-17 21:56:01 UTC 
Yes, that is the fix I have edited in my backupiso file but I will be testing it tomorrow morning as it is getting late here now.
Comment 3 Adolf Belka 2022-09-18 11:29:15 UTC 
Fix confirmed to work on my vm testbed system.

Also confirmed on the forum:-
https://community.ipfire.org/t/backup-pl-fails-to-create-full-iso-backup-after-core-update-170/8592/4
Comment 4 Adolf Belka 2022-09-18 11:49:40 UTC 
Patch submitted to dev mailing list and patchwork.

https://patchwork.ipfire.org/project/ipfire/patch/20220918114517.7508-1-adolf.belka@ipfire.org/
Comment 7 Adolf Belka 2022-10-06 12:11:43 UTC 
Tested this on CU171 Testing on my vm testbed.

It didn't work but after some thought and checking I relaised that is because it downloads the original iso file from the standard IPFire downloads url and Core Update 171 is not yet available there as it is in Testing phase.

So this bug will only be able to be formally verified when Core Update 171 Stable is released.