Bug 12868 - PAKFIRE WARN: Not a known option --no-colors
Summary: PAKFIRE WARN: Not a known option --no-colors
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - Minor Usability
Assignee: Robin Roevens
QA Contact: Michael Tremer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-19 21:11 UTC by Jon
Modified: 2022-09-16 09:22 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon 2022-05-19 21:11:38 UTC
The command works as expected but it throws an error.

```
[root@ipfire ~] # /usr/local/bin/pakfire list --no-colors 
PAKFIRE WARN: Not a known option --no-colors
Name: 7zip
ProgVersion: 17.04
Release: 9

Name: alac
ProgVersion: 0.0.7
Release: 1

IPFire 2.27 (x86_64) - Core Update 167
```

Also - without colors there is no way to determine what is installed and what is not installed.  Please add text for "Installed Item"
Comment 1 Peter Müller 2022-06-28 14:20:03 UTC
@Michael: Could you take care of this?
Comment 2 Michael Tremer 2022-06-29 18:48:22 UTC
In this patch, Robin has added an extra parameter to the list command which allows to only list installed or not-installed packages:

> https://patchwork.ipfire.org/project/ipfire/patch/20220309225655.4472-2-robin.roevens@disroot.org/

I would propose to get this patchset ready to be merged and then this ticket should be solved.

Please let me know if this is what you were looking for.
Comment 3 Jon 2022-06-29 21:41:33 UTC
Yes, it looks like it will work!

---

Side thought - does Robin's code need to be updated?  It was submitted in March.

Leo added a bunch of patches on May 8 and one on June 4.

https://git.ipfire.org/?p=ipfire-2.x.git;a=search;h=HEAD;s=Leo-Andres+Hofmann;st=author
Comment 4 Robin Roevens 2022-06-29 22:49:57 UTC
Yes, it needs to be updated. Not necessarily due to changes in current next since march, but since this patch is part of a set and there where a few smaller and bigger remarks that needed to be addressed. 
I have an updated set ready for already 3 months but was waiting on mailing list users feedback on some translations which Michael noticed that should also be included.
However discussion on the mailinglist dropped dead, .. so I'm hoping it can be picked up soon, and I can submit the new version.
Comment 5 Michael Tremer 2022-07-01 17:05:04 UTC
(In reply to Robin Roevens from comment #4)
> Yes, it needs to be updated. Not necessarily due to changes in current next
> since march, but since this patch is part of a set and there where a few
> smaller and bigger remarks that needed to be addressed. 
> I have an updated set ready for already 3 months but was waiting on mailing
> list users feedback on some translations which Michael noticed that should
> also be included.

Please push for these things. I am sorry that I am sometimes taking a very long time to respond. It doesn't hurt to ping me a little bit. If I don't respond I am probably busy :)

> However discussion on the mailinglist dropped dead, .. so I'm hoping it can
> be picked up soon, and I can submit the new version.

What do we need to do to pick this up again?
Comment 6 Robin Roevens 2022-07-28 11:30:33 UTC
The error 
```
PAKFIRE WARN: Not a known option --no-colors
```
is fixed in https://patchwork.ipfire.org/project/ipfire/patch/20220728112136.30218-7-robin.roevens@disroot.org/

New text "Installed: Yes/No" is fixed in https://patchwork.ipfire.org/project/ipfire/patch/20220728112136.30218-2-robin.roevens@disroot.org/

The whole patchset was revised an resubmitted to the mailinglist.
Comment 9 Jon 2022-08-24 02:22:17 UTC
Tested on APU4d4 with IPFire 2.27 (x86_64) - Core-Update 170 Development Build: master/ef7d41ef

```
Name: firmware-update
ProgVersion: 20210107
Release: 2
Installed: yes

Name: flac
ProgVersion: 1.3.3
Release: 3
Installed: no

```

All works A-OK with or without colors!