ncat 7.91 crash with segfault if virtmanager try to connect libvirt (ssh)
I reverted this in master for now: > https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=addeeb1f79825fdf2e03c089d661686050b336d5
So I have had a search on this in the nmap repository. nmap-7.91 was released on Oct 10th 2020. seg fault issue was identified on Oct 15th 2020. https://github.com/nmap/nmap/issues/2154 patch to fix was committed on Oct 16th 2020 Issue was closed in nmap repository on Oct 16th 2020 818 closed issues in the nmap repository I will create a patch to use the nmap patch and post it here in bugzilla so it can be tested and confirmed to solve the problem we are having.
Sounds good. Thank you.
Just to check. I need to do my patch submission against master and not next as the reversion is showing up in master but not in next.
Yes, please.
Created attachment 914 [details] patch file for testing of segfault fix As per https://github.com/nmap/nmap/issues/2154 I ran the following commands with the old version of ncat-7.91 -bash-5.1$ touch /tmp/foo -bash-5.1$ nc -U /tmp/foo and got the result Segmentation fault Then I uninstalled that version and installed the .ipfire package built with the patch from nmap/issues/2154 then re-ran -bash-5.1$ nc -U /tmp/foo and got Ncat: Connection refused. So the patch worked for me using the above commands. If someone could try my IPFire build patch with the libvirt commands to confirm it also works with the issue that raised the bug in the first place. If it works then I will submit into the development mailing list.
if I remember correctly, the problem with me also occurred only after the last update of ncat.
That's correct. The problem was caused in the 7.91 release of ncat (nmap). ncat was reverted from 7.91 to 7.80 in the master repository. I have then redone the update from 7.80 to 7.91 but including the patch created by the nmap team to fix this problem.
Patch submitted to patchwork https://patchwork.ipfire.org/project/ipfire/patch/20210803131111.1523787-1-adolf.belka@ipfire.org/
Resetting this back to ASSIGNED since the patch has not been merged yet.
Patch has been merged into next - Core Update 160 https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=999b71cf47dc120eb1b0e558dc6a8dbbf66f7a17
https://blog.ipfire.org/post/ipfire-2-27-core-update-160-available-for-testing
Tested out the fix in Core Update 160 Testing by doing: -bash-5.1$ touch /tmp/foo -bash-5.1$ nc -U /tmp/foo and got the result Ncat: Connection refused. and no longer Segmentation Fault. This indicates that the problem has been fixed. It would be good if someone using libvirt could try it with Core Update 160 Testing to confirm it solves the original problem.
You can set the status to VERIFIED if there is sufficient feedback that this bug is fixed. I suppose one tester is enough for a segfault, but it might vary on other issues.
https://blog.ipfire.org/post/ipfire-2-27-core-update-160-released