Bug 12605 - (Core Update 156 - testing) All graphs on web interface are not displaying correctly
Summary: (Core Update 156 - testing) All graphs on web interface are not displaying co...
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all All
: - Unknown - Aesthetic Issue
Assignee: Leo Hofmann
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-14 13:55 UTC by Matt S
Modified: 2021-10-23 11:09 UTC (History)
3 users (show)

See Also:


Attachments
pic of screen (353.35 KB, image/jpeg)
2021-04-14 13:55 UTC, Matt S
Details
from Chrome ios (540.48 KB, image/png)
2021-04-14 19:31 UTC, velifire
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt S 2021-04-14 13:55:13 UTC
Created attachment 875 [details]
pic of screen

In the Web interface all graphs  such as CPU , CPU freq, Load average,memory, etc 
are being rendered incorrectly.  The graph size is small and the information below the graphs is missing.

I don't see any errors in /var/log/messages

however in the httpd logs I do see this
[Sun Apr 11 20:39:08.722583 2021] [core:error] [pid 30531:tid 132817040148032] (13)Permission denied: [client 10.0.0.206:57263] AH00035: access to /cgi-bin/pakfire.cgi denied (filesystem path '/srv/web') because search permissions are missing on a component of the path, referer: https://10.0.0.1:444/
[Sun Apr 11 20:39:08.758581 2021] [core:error] [pid 30531:tid 132817193334336] (13)Permission denied: [client 10.0.0.206:57263] AH00035: access to /favicon.ico denied (filesystem path '/srv/web') because search permissions are missing on a component of the path, referer: https://10.0.0.1:444/
Comment 1 Matt S 2021-04-14 13:57:05 UTC
I should have mentioned this is on Core Update 156 Development Build
Comment 2 Leo Hofmann 2021-04-14 16:30:53 UTC
Hi Matt,
thank you for reporting this. I have installed the current testing release and can reproduce the error.

As far as I can tell, this patchset has not been fully merged yet:
https://patchwork.ipfire.org/patch/4013/

Once these changes are accepted, the graphs should work as expected.
If you want, can you please apply the patch manually and test again?
Comment 3 Matt S 2021-04-14 16:50:21 UTC
This patch seems to be for a build tree and not a running system, so unfortunately I can't test quickly as I don't have a build system up.  I will see if I can find some time to get a build tree.
Comment 4 velifire 2021-04-14 19:31:13 UTC
Created attachment 877 [details]
from Chrome ios
Comment 5 Michael Tremer 2021-04-15 11:12:35 UTC
(In reply to Leo Hofmann from comment #2)
> Hi Matt,
> thank you for reporting this. I have installed the current testing release
> and can reproduce the error.
> 
> As far as I can tell, this patchset has not been fully merged yet:
> https://patchwork.ipfire.org/patch/4013/
> 
> Once these changes are accepted, the graphs should work as expected.
> If you want, can you please apply the patch manually and test again?

As far as I am aware this patchset is fully merged:

> https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=9c6a0ce12d01e8b2cab28d7061e18f905ae3b38c

Could you please double-check for me if I forgot to include a file in the updater? I could not find anything.
Comment 6 Matt S 2021-04-15 11:52:13 UTC
I juust updated to the unstable build:
IPFire 2.25 (x86_64) - Core Update 157 Development Build: next/9f2ee0e9

and the issue is still present.
Comment 7 Leo Hofmann 2021-04-15 21:28:31 UTC
(In reply to Michael Tremer from comment #5)
> As far as I am aware this patchset is fully merged:

Looks okay to me! I wasn't sure, because in Patchwork it still has the status "new".

> Could you please double-check for me if I forgot to include a file in the
> updater? I could not find anything.

Do you mean core/156/filelists/files and filelists/web-user-interface?
That also looks all right to me!

But on my test system I noticed something: The file /var/ipfire/graphs.pl was not updated with core 156. In my update-core-upgrade-156.log, graphs.pl is not mentioned at all. I think this could be the problem?
Comment 8 Michael Tremer 2021-04-16 10:23:46 UTC
(In reply to Leo Hofmann from comment #7)
> (In reply to Michael Tremer from comment #5)
> > As far as I am aware this patchset is fully merged:
> 
> Looks okay to me! I wasn't sure, because in Patchwork it still has the
> status "new".

It sometimes does this which is quite annoying. The longer the patch the more likely it is to happen and probably simply is because of special characters that seem to generate a different hash.

> > Could you please double-check for me if I forgot to include a file in the
> > updater? I could not find anything.
> 
> Do you mean core/156/filelists/files and filelists/web-user-interface?
> That also looks all right to me!

Yes.

> But on my test system I noticed something: The file /var/ipfire/graphs.pl
> was not updated with core 156. In my update-core-upgrade-156.log, graphs.pl
> is not mentioned at all. I think this could be the problem?

Sounds like it. I will add it.
Comment 9 Michael Tremer 2021-04-16 10:24:33 UTC
(In reply to Michael Tremer from comment #8)
> Sounds like it. I will add it.

False alarm. It is in there:

> root@michael:/build/ipfire-2.x# git grep graphs.pl$ config/rootfiles/core/
> config/rootfiles/core/156/filelists/files:var/ipfire/graphs.pl
Comment 10 Leo Hofmann 2021-04-16 15:01:18 UTC
(In reply to Michael Tremer from comment #9)
> (In reply to Michael Tremer from comment #8)
> > Sounds like it. I will add it.
> 
> False alarm. It is in there:
> 
> > root@michael:/build/ipfire-2.x# git grep graphs.pl$ config/rootfiles/core/
> > config/rootfiles/core/156/filelists/files:var/ipfire/graphs.pl

It is in the file list. But on my test system it was not installed during the update. I now did a clean install of core 155 to double check.

# cp /var/ipfire/graphs.pl /var/ipfire/graphs.pl.155
# pakfire status
Core-Version: 2.25-x86_64
Core-Update-Level: 155

Switch pakfire to testing branch, install update, reboot:
pakfire2/2.25.1-x86_64/paks/core-upgrade-2.25-156.ipfire has size of 17843658 bytes

# cp /var/ipfire/graphs.pl /var/ipfire/graphs.pl.156
# pakfire status
Core-Version: 2.25.1-x86_64
Core-Update-Level: 156

# diff -s /var/ipfire/graphs.pl.155 /var/ipfire/graphs.pl.156
Files /var/ipfire/graphs.pl.155 and /var/ipfire/graphs.pl.156 are identical

I don't understand what is happening here?
After the update, I checked it with an editor. graphs.pl was definitely not updated correctly for me.
Please let me know if I can try anything else!
Comment 11 velifire 2021-04-17 12:16:42 UTC
Can you confirm the bug cannot be reproduced from the browser on your mobile device

When I test on latest Chrome from iPhone 8 I cannot reproduce the bug


Hope this helps to exclude certain investigation paths
Comment 12 velifire 2021-04-17 12:25:07 UTC
in addition to desktop chrome it is reproduceable also in 
- desktop safari, 
- desktop firefox
- mobile safari

so I infer, desktop chrome has a bug !
Comment 13 Michael Tremer 2021-04-19 10:11:08 UTC
Please re-install the core update again. There was a problem with collecting all files and putting them into the image although they were listed to be included.

After reinstalling, it should work fine.
Comment 14 Leo Hofmann 2021-04-20 17:14:43 UTC
(In reply to Michael Tremer from comment #13)
> Please re-install the core update again. There was a problem with collecting
> all files and putting them into the image although they were listed to be
> included.
> 
> After reinstalling, it should work fine.

I reinstalled the update on my test VM and can confirm that this solved the problem. Thank you for fixing the update file!
Comment 15 Peter Müller 2021-10-23 11:09:21 UTC
Assuming this is being fixed in Core Update 160, since graphs are now given as SVG images. Please reopen, if necessary.

https://blog.ipfire.org/post/ipfire-2-27-core-update-160-released