Bug 12505 - Update procps
Summary: Update procps
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Adolf Belka
QA Contact:
URL:
Keywords:
Depends on:
Blocks: KERNEL5
  Show dependency treegraph
 
Reported: 2020-10-19 15:21 UTC by Michael Tremer
Modified: 2021-03-08 17:42 UTC (History)
2 users (show)

See Also:


Attachments
lfs for procps-v3.3.16 (3.18 KB, text/x-matlab)
2020-12-22 21:46 UTC, Adolf Belka
Details
log for the cdrom stage when fails occur (1.35 KB, text/x-log)
2020-12-22 21:47 UTC, Adolf Belka
Details
log for build of procps-v.3.3.16 (32.67 KB, text/x-log)
2020-12-22 21:49 UTC, Adolf Belka
Details
modified make.sh to have procps later in the lfmake2 sequence (47.50 KB, application/x-shellscript)
2020-12-22 21:56 UTC, Adolf Belka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tremer 2020-10-19 15:21:44 UTC
Our version of sysctl(8) seems to be outdated and occasionally logs this message:

> Oct 19 11:53:47 fw01 kernel: ICMPv6: process `sysctl' is using deprecated sysctl (syscall) net.ipv6.neigh.blue0.base_reachable_time - use net.ipv6.neigh.blue0.base_reachable_time_ms instead

An update should help.
Comment 1 Adolf Belka 2020-12-20 13:44:18 UTC
I have got the latest procps file and have modified the lfs file.

I have noticed that in the lfs file there is a patch file

/src/patches/$(THISAPP)-fix_unknown_HZ_value.patch

I had a look through the patch and googled on the problem of unknown hz value and found this bug mentioned from back in 2010.

Looking at the lines being changed by the patch many of the lines being removed no longer exist in the specified files. I suspect that even if the patch is still needed so much has changed that the patch needs to be rewritten.

Unfortunately my knowledge is not enough to figure out if the patch is still needed and if so how it should be implemented.

How can I get some help with what should be done with this fix_unknown_HZ_value.patch.
Comment 2 Michael Tremer 2020-12-21 16:32:09 UTC
It looks like procps is no longer maintained. LFS has switched to procps-ng which does not seem to need any patches:

> http://www.linuxfromscratch.org/lfs/view/stable/chapter08/procps-ng.html

You could integrate this and replace procps as long as all commands are still available. You should be able to see that from the rootfile.
Comment 3 Adolf Belka 2020-12-22 21:46:16 UTC
Created attachment 824 [details]
lfs for procps-v3.3.16
Comment 4 Adolf Belka 2020-12-22 21:47:09 UTC
Created attachment 825 [details]
log for the cdrom stage when fails occur
Comment 5 Adolf Belka 2020-12-22 21:49:57 UTC
Created attachment 826 [details]
log for build of procps-v.3.3.16
Comment 6 Adolf Belka 2020-12-22 21:55:24 UTC
So I built procps-v3.3.16 (procps-ng)

I had to use autogen.sh as there was no configure script. the lfs file is attached.

Using autogen.sh meant that I had to shift procps further down the list in make.sh as it required libtool, gettext and pkg-config to be run beforehand.

Having done the above procps then built with no errors.

However at the cdrom stage I have been getting fails that I have been unable to find a solution to.
I attach the logs, lfs file and make.sh file. I would appreciate any guidance on what I need to fix to clear up the errors I am getting.

The build is being done against next (Core 154).
Comment 7 Adolf Belka 2020-12-22 21:56:09 UTC
Created attachment 827 [details]
modified make.sh to have procps later in the lfmake2 sequence
Comment 8 Michael Tremer 2020-12-23 09:48:25 UTC
(In reply to Adolf Belka from comment #6)
> So I built procps-v3.3.16 (procps-ng)
> 
> I had to use autogen.sh as there was no configure script. the lfs file is
> attached.
> 
> Using autogen.sh meant that I had to shift procps further down the list in
> make.sh as it required libtool, gettext and pkg-config to be run beforehand.

That is fine.

> Having done the above procps then built with no errors.
> 
> However at the cdrom stage I have been getting fails that I have been unable
> to find a solution to.
> I attach the logs, lfs file and make.sh file. I would appreciate any
> guidance on what I need to fix to clear up the errors I am getting.

This is just the old rootfile that needs to be updated. I suppose some tools might have been moved from /bin to /usr/bin and you might want to consider to move them back to /bin after the build.

Here is an example:

> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=lfs/kbd;h=590f8afe702a3ccbb734f53fbebe2d4fe2a7ef7d;hb=HEAD

It is also always easier for me to read a diff than multiple files attached to a ticket :)
Comment 9 Adolf Belka 2020-12-26 11:39:18 UTC
(In reply to Michael Tremer from comment #8)
> 
> This is just the old rootfile that needs to be updated. I suppose some tools
> might have been moved from /bin to /usr/bin and you might want to consider
> to move them back to /bin after the build.
> 
> Here is an example:
> 
> > https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=lfs/kbd;h=590f8afe702a3ccbb734f53fbebe2d4fe2a7ef7d;hb=HEAD

Thanks very much for the guidance. That helped a lot. Will remember for the future.

> 
> It is also always easier for me to read a diff than multiple files attached
> to a ticket :)

Of course it would be. Noted for future use.
Comment 10 Adolf Belka 2020-12-26 16:55:29 UTC
Build of procps-v3.3.16 successfully carried out with help and guidance of Michael.

Tested successfully on IPFire test bed system and patch submitted to list.

https://patchwork.ipfire.org/patch/3757/
Comment 13 Adolf Belka 2021-03-08 17:42:31 UTC
patch has been released with Core Update 154