Bug 12496 - WUI firewallhits Graph Wrong Average for NewNotSYN
Summary: WUI firewallhits Graph Wrong Average for NewNotSYN
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: Will affect all users Aesthetic Issue
Assignee: Michael Tremer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-10 20:13 UTC by Charles Brown
Modified: 2020-11-20 19:04 UTC (History)
3 users (show)

See Also:

Attachments
https://ipfire:444/cgi-bin/netother.cgi (92.51 KB, image/png)
2020-10-11 15:23 UTC, Charles Brown 		Details
Zoomed out for a little more perspective (166.97 KB, image/png)
2020-10-11 15:31 UTC, Charles Brown 		Details
Min greater than Max (31.34 KB, image/png)
2020-11-20 19:02 UTC, Charles Brown 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Brown 2020-10-10 20:13:10 UTC 
In the WUI, On Network (others) → firewallhits Graph on the NewNotSYN row, the value in the Average column shows zero even when min and max on that row have values greater than zero.

https://community.ipfire.org/t/newnotsyn-firewallhits-average/3389
Comment 1 Michael Tremer 2020-10-11 11:15:06 UTC 
Could you please post the graph that shows the error?
Comment 2 Charles Brown 2020-10-11 15:23:03 UTC 
Created attachment 784 [details]
https://ipfire:444/cgi-bin/netother.cgi
Comment 3 Charles Brown 2020-10-11 15:31:51 UTC 
Created attachment 785 [details]
Zoomed out for a little more perspective
Comment 4 Michael Tremer 2020-10-12 10:30:20 UTC 
The values were just mixed up:

https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=79131c6e47e535452625028477101ec59203e476

You can download the graphs.pl file and copy it to /var/ipfire/graphs.pl to test and confirm this fix.
Comment 5 Charles Brown 2020-10-12 10:45:05 UTC 
Looks good, thanks.
Comment 8 Charles Brown 2020-11-20 19:02:58 UTC 
Created attachment 805 [details]
Min greater than Max

I updated to 152 but I am seeing weird values in the tables -- should I expect "mBps" values in in min while max has "kBps" values?
Comment 9 Michael Tremer 2020-11-20 19:04:51 UTC 
Yes this is correct. It is not "MBps" (as in mega), but milli as in millilitre.

rrdtool (which generates the graphs) is made for scientific stuff but it is very useless to use millibits/s. Statistically it makes sense.