Bug 12267 - DNS: Remove using old DNS files
Summary: DNS: Remove using old DNS files
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Stefan Schantl
QA Contact:
URL:
Keywords:
Depends on:
Blocks: DNSNG
  Show dependency treegraph
 
Reported: 2020-01-08 10:24 UTC by Michael Tremer
Modified: 2020-03-07 19:03 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Tremer 2020-01-08 10:24:54 UTC
There are a couple of CGIs that read files that we no longer provide.

Would you please have a look at them and maybe add a function to network-functions.pl that returns the currently used DNS servers?

I found at least the following:

> [root@fw01 ipfire-2.x]# git grep "red/dns"
> config/cfgroot/general-functions.pl:    my $path = "${General::swroot}/red/dnssec-status";
> config/cfgroot/ids-functions.pl:        open (FILE, "${General::swroot}/red/dns") or die "Could not read DNS configuration from ${General::swroot}/red/dns. $!\n";
> html/cgi-bin/guardian.cgi:      my $dns1file = "${General::swroot}/red/dns1";
> html/cgi-bin/guardian.cgi:      my $dns2file = "${General::swroot}/red/dns2";
> html/cgi-bin/guardian.cgi:      my $dns1file = "${General::swroot}/red/dns1";
> html/cgi-bin/guardian.cgi:      my $dns2file = "${General::swroot}/red/dns2";
> html/cgi-bin/index.cgi: if ( -e "${General::swroot}/red/dns" ) {
> html/cgi-bin/index.cgi:         open (TMP, "<${General::swroot}/red/dns");
Comment 1 Peter Müller 2020-03-07 09:30:22 UTC
What is the status of this bug?
Comment 2 Stefan Schantl 2020-03-07 12:59:26 UTC
I think the bug safely can be closed because when doing the same git grep on the current master ( Core 141 ) there are no entries anymore to an old red dns file.

root@tuxedo:/home/ipfire-2.x# git grep "red/dns"
config/cfgroot/general-functions.pl:    my $path = "${General::swroot}/red/dnssec-status";
Comment 3 Peter Müller 2020-03-07 19:03:56 UTC
I see, thanks for the reply.