Bug 12008 - Typo in 'proxy.cgi' leads to wrong path for ' basic_ldap_auth'
Summary: Typo in 'proxy.cgi' leads to wrong path for ' basic_ldap_auth'
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all Linux
: Will affect almost no one Minor Usability
Assignee: Matthias Fischer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-26 19:40 UTC by Matthias Fischer
Modified: 2019-05-02 15:51 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fischer 2019-02-26 19:40:34 UTC 
Triggered by:

https://forum.ipfire.org/viewtopic.php?f=17&t=22370 (german)

Typo in 'proxy.cgi' in line 104:

...
my $authdir  = "/usr/lib/squid/";
...

Last slash leads to wrong path with double slash:

auth_param basic program /usr/lib/squid//basic_ldap_auth (...)

Line in 'proxy.cgi' should read:

...
my $authdir  = "/usr/lib/squid";
...

Work in progress...

Best,
Matthias
Comment 1 Michael Tremer 2019-02-27 15:18:43 UTC 
Will you submit a patch?

The author didn't write what does not work, but I suppose squid is no longer able to start the authentication sub-process?
Comment 2 Matthias Fischer 2019-02-27 17:10:43 UTC 
Exactly.

As I read it, the last slash leads to a wrong path and authentication fails/cannot start.

I can't test this here - I'm trusting the positive feedback from the OP.

I will submit a patch on weekend, no problem.

Best,
Matthias

P.S.: Forgot to "take" this Bug, sorry - was a bit early in the morning... ;-)
Comment 3 Matthias Fischer 2019-05-02 15:51:56 UTC 
Fiexed in Core 129.