Bug 11505 - Captive Portal: no way to remove an uploaded logo
Summary: Captive Portal: no way to remove an uploaded logo
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - Minor Usability
Assignee: Alexander Marx
QA Contact: Michael Tremer
URL:
Keywords: NewFeature
Depends on:
Blocks:
 
Reported: 2017-10-16 10:16 UTC by Daniel Weismüller
Modified: 2019-06-28 10:39 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Weismüller 2017-10-16 10:16:35 UTC 
If you have uploaded a logo you cannot remove it within the captive portal.
Comment 1 Alexander Marx 2018-05-15 07:28:06 UTC 
Ok. checked and confirmed
Will work on this
Comment 2 Alexander Marx 2018-05-15 07:40:17 UTC 
Well seems someone changed the code.
In my original version the logo is shown on the config page.

Can someone tell me why that was changed? Was there a special reason for that?
Comment 3 Michael Tremer 2018-05-15 12:12:01 UTC 
As far as I remember I have never seen the logo being on the config page. I
changed code and I may have removed it by accident, but I do not remember that
it has ever been there.
Comment 4 Alexander Marx 2018-05-22 12:44:21 UTC 
Yes. the function was edited and i had code for checking the dimensions and type of the logo.
It makes sense to display it in the config page. I would recode the function and add a "Delete" Button for removing the Logo if that is ok for you.
Comment 5 Michael Tremer 2018-05-22 12:48:29 UTC 
For this ticket, please just add the button.
Comment 6 Alexander Marx 2018-05-24 12:42:57 UTC 
Added a button. Please test
Comment 7 Alexander Marx 2018-05-24 12:43:25 UTC 
https://patchwork.ipfire.org/patch/1782/
Comment 8 Peter Müller 2019-05-11 10:13:08 UTC 
Has this patch been merged? I cannot find it on git.ipfire.org. :-/

If yes, I assume this can be closed as FIXED.
Comment 9 Peter Müller 2019-06-28 10:39:04 UTC 
Assuming this is fixed. If it is not, please reopen.

Looking forward to more commit IDs reported in fixed bug in future lives... :-)

Thank you.