Bug 11338 - Wrong font-sizes in the FireInfo module
Summary: Wrong font-sizes in the FireInfo module
Status: CLOSED NOTABUG
Alias: None
Product: Infrastructure
Classification: Unclassified
Component: Web Site (show other bugs)
Version: unspecified
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Sven Hoehn
QA Contact: Michael Tremer
URL:
Keywords:
Depends on:
Blocks: 11314
  Show dependency treegraph
 
Reported: 2017-05-02 22:03 UTC by Maurice Gesswein
Modified: 2018-11-05 18:54 UTC (History)
1 user (show)

See Also:


Attachments
fireinfo_fonts (54.69 KB, image/png)
2017-05-02 22:03 UTC, Maurice Gesswein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maurice Gesswein 2017-05-02 22:03:24 UTC
Created attachment 515 [details]
fireinfo_fonts

Please recheck the font-sizes in the FireInfo module at viewport M, S & XS and compare with designs in Zeplin. See attached example of viewport M.
Comment 1 Maurice Gesswein 2017-05-07 21:02:56 UTC
Headlines like 'Latest Release' are still to small in M, S and XS. 10px instead of 14px and font-weight 300 instead of 400. Also the %-values are not vertically centered anymore. Looks perfect and L and XL.
Comment 2 Sven Hoehn 2017-05-11 11:30:03 UTC
please check again font-size.
Comment 3 Maurice Gesswein 2017-05-15 21:15:01 UTC
Almost. At S and XS the headline like "Intel" should be 16px instead of 20px. Could you also replace "top: calc(50% - 20px)" with "top: calc(50% - 18px)", please?

And one question about the font color of the percent values: I see "#546e7a" at the code. It should be "rgba:(38, 50, 56, 0.6);". Primary color with 60% opacity. We need transparency at the fonts when these are located on colored background. This will avoid to use additional colors for fonts. As in Zeplin sheet https://zpl.io/Z1LkANx these 6 colors for fonts will be all we need to cover almost all cases.

Hint: You can click on the small gear next to "CSS" (hover of it) at Zeplin to change HEX to RGB and more options.
Comment 4 Sven Hoehn 2017-06-15 19:12:21 UTC
please check again.

On Zeplin I only see the rgb value but not the rgba value and therefor no transparency.