Bug 11312 - GeoIP name changes will not reapply the rules
Summary: GeoIP name changes will not reapply the rules
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all All
: Will affect an average number of users Minor Usability
Assignee: Alexander Marx
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-05 17:49 UTC by Thomas B
Modified: 2018-10-15 13:48 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas B 2017-04-05 17:49:10 UTC 
Hallo

1.) ich habe mir eine Geoip-Gruppe erstellt "GrpA"

2.) mit dieser Gruppe habe ich mehrere unterschiedliche Rules erstellt.

3.) dann die Geoip-Gruppe auf "GrpB" geändert

4.) In den Rules steht noch GrpA, erst nach dem ändern der Rule, steht der neue Gruppenname da und das führt dann zum neueinlesen der Rules.

Hello

1.) I have create a geoipgroup "grpA"

2.) create various firewallrules with this group

3.) then go back and change the name of the geoipgroup to "grpB"

4.) in the firewallrules is still the old geoupname "grpA"

but when I click to change the rule, then is in the pulldownmenu the new name of the group and after save, I have the button "change ruleset"

I hope it helps...
Comment 1 Michael Tremer 2017-04-05 22:14:28 UTC 
Please post in English only. ASSIGNED.
Comment 2 Peter Müller 2017-11-08 17:43:44 UTC 
This issue can be reproduced here.
Comment 3 Alexander Marx 2018-04-05 12:09:10 UTC 
I can confirm this. 
A closer look showed that the group is not only stored as groupname, instead, the firewall config stores it like "group:<grpname>". 

Adapted function to rename group in the firewallrules. Should work.
BUG 11312 is fixed and patch is in pipeline.
Comment 4 Michael Tremer 2018-04-05 13:03:31 UTC 
Great! Thanks for having a look and fixing this.
Comment 5 Peter Müller 2018-04-26 17:19:59 UTC 
https://patchwork.ipfire.org/patch/1718/

Testing. Will report.
Comment 6 Peter Müller 2018-04-26 17:26:41 UTC 
I can confirm that the patch solves the problem. However, it has a blank line with trailing whitespace so I would like to send in a second version of this.
Comment 7 Peter Müller 2018-04-26 17:32:30 UTC 
Sent slightly improved patch to mailing list: https://patchwork.ipfire.org/patch/1729/
Comment 8 Alexander Marx 2018-05-28 10:23:15 UTC 
https://patchwork.ipfire.org/patch/1718/

Please have a look and test this patch