Bug 10700 - Squid-Accounting: Squid-Accounting is shown as addon service
Summary: Squid-Accounting: Squid-Accounting is shown as addon service
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Alexander Marx
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-16 00:47 UTC by Tobias Klein
Modified: 2017-11-09 10:24 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Klein 2014-12-16 00:47:33 UTC
Services.cgi generates dynamically the addon-services view.
In this view the squid-accounting addon is shown as 'squid' because of the '-' cut off.
Squid accounting is a cronjob so I think this view is not needed.
I generated a diff file for the services.cgi where I added a exclusion for the generation of the services view.

--- /root/services.cgi  2014-12-16 00:27:55.924305101 +0100
+++ /srv/web/ipfire/cgi-bin/services.cgi        2014-12-16 00:23:46.764311620 +0100
@@ -188,7 +188,7 @@
                        # mdadm should not stopped with webif because this could crash the system
                        #
                        chomp($_);
-                       if ( ($_ ne "alsa") && ($_ ne "mdadm") ) {
+                       if ( ($_ ne "alsa") && ($_ ne "mdadm") && ($_ ne "squid") ) {
                                $lines++;
                                if ($lines % 2){
                                        print "<tr>";
Comment 1 Alexander Marx 2016-09-08 08:48:32 UTC
already fixed
Comment 2 Daniel Weismüller 2016-09-08 09:10:49 UTC
(In reply to Alexander Marx from comment #1)
> already fixed

I recently installed squid-accounting 1.0.4-9 on my testipfire Core 104.

I looked at Status - Services and found an entry "squid" in the area "Addon - Services"

Please recheck it.
Comment 3 Alexander Marx 2016-09-08 09:25:18 UTC
I don't know why it is shown in your installation.
As you can check in the GIT (next branch) the file services.cgi says:
  




 185                         # blacklist some packages
 186                         #
 187                         # alsa has trouble with the volume saving and was not really stopped
 188                         # mdadm should not stopped with webif because this could crash the system
 189                         #
 190                         chomp($_);
 191                         if ( $_ eq 'squid' ) {
 192                                 next;
 193                         }

which skippes the service in the addon part. I just installed stable core 103 and the code does what it should.
Please tripplecheck by installing a fresh IPFire version and check the corresponding lines in the services.cgi
Comment 4 Peter Müller 2017-11-08 17:41:41 UTC
Is this bug still valid? (Currently cleaning up the bug list... :-) )
Comment 5 Tobias Klein 2017-11-09 10:24:05 UTC
No problem is solved.