Bug 10630 - Squid-Accounting invalid preview file-extension
Summary: Squid-Accounting invalid preview file-extension
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: i686 All
: - Unknown - Balancing
Assignee: Alexander Marx
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-23 18:50 UTC by Tobias Klein
Modified: 2015-02-25 10:36 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Klein 2014-09-23 18:50:25 UTC
When you click on billgroup and want to see the bill-preview then the preview extension is 'tmp.pdf' so that you can't open the pdf-file.

In accouting.cgi on line 102 the '' has to remove.
Then is file extension valid.

Diff from /srv/web/ipfire/cgi-bin/accounting.cgi

--- /srv/web/ipfire/cgi-bin/accounting.cgi      2014-09-23 18:30:11.983180155 +0200
+++ /root/accounting.cgi        2014-09-23 18:43:40.929825741 +0200
@@ -99,7 +99,7 @@
        print "Content-Type:application/pdf\n";
        my @fileinfo = stat($tempfile);
        print "Content-Length:$fileinfo[7]\n";
-       print "Content-Disposition:attachment;filename=tmp.pdf;\n\n";
+       print "Content-Disposition:attachment;filename='tmp.pdf';\n\n";
        print @fileholder;
        unlink ($tempfile);
        exit (0);
Comment 1 Alexander Marx 2015-02-25 10:36:41 UTC
Already fixed and committed