These strings are presented to the user and not properly translated: > [root@gate ipfire-2.x]# git grep \$type html/cgi-bin/fwhosts.cgi > html/cgi-bin/fwhosts.cgi: $type='Standard Network'; > html/cgi-bin/fwhosts.cgi: $type='Custom Network'; > html/cgi-bin/fwhosts.cgi: $type='Custom Host'; > html/cgi-bin/fwhosts.cgi: $type='OpenVPN static network'; > html/cgi-bin/fwhosts.cgi: $type='OpenVPN static host'; > html/cgi-bin/fwhosts.cgi: $type='OpenVPN N-2-N'; > html/cgi-bin/fwhosts.cgi: $type='IpSec Host'; > html/cgi-bin/fwhosts.cgi: $type='IpSec Network';
This is NOT true. These strings are only used to save the hostgroups in the hashfile and are never presented to users. We are not able to use translated strings here, as it would break the groups if we save a group with language settings "german" then change to "english" and try to modify old groups. For this it is neccessary to have UNIQUE strings in the hash and that is what these strings do.
Now the Strings are translated for german and english http://git.ipfire.org/?p=people/amarx/ipfire-2.x.git;a=commit;h=7fc0347b70b0abfdf2c58e2613ea3ec01312dc09
Created attachment 198 [details] Screenshot with broken strings This actually *is* a bug as you can see in the attached screenshot. Obviously I cannot merge this as it breaks rules from the configuration files. It reverts changes introduced in an other commit and none of the typos is actually fixed. I am really tired to deal with the same issues over and over again.
This BUG also affects the convert-outgoingfw converter. http://git.ipfire.org/?p=people/amarx/ipfire-2.x.git;a=commit;h=cd4d102b93cede9f876aaba06f9848ca482e4cbf
Once again, the configuration format can not be changed any more. There are plenty of systems out there and this will break all of them unless you build yet an other converter to fix this. I really don't care what string is there in the configuration file. Either if it is "Custom Host" or "CH". It is not good style to have lots of typos in here, but as long as it is unique and parsable, I don't care. So, there are two options now: a) build a converter that fixes the intermediate configuration or b) leave it as it is and just fix the strings that are presented to the user. I would really like to see this fixed swiftly.
Commit already merged