Bug 10504 - UpdateXLRator keeps redownloading the same file if + or ~ in the URL
Summary: UpdateXLRator keeps redownloading the same file if + or ~ in the URL
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all All
: - Unknown - Minor Usability
Assignee: jluth
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 11558
  Show dependency tree / graph
 
Reported: 2014-04-04 13:12 UTC by jluth
Modified: 2018-10-15 13:51 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jluth 2014-04-04 13:12:06 UTC 
A bug in /usr/sbin/updxlrator keeps downloading the same file (especially noticeable with Ubuntu kernels) if there is a "+" or "~" in the URL.

That's because /var/ipfire/updatexlrator/bin/download modifies the sourceurl with these regexs:
    $sourceurl =~ s@\%2b@+@ig;
    $sourceurl =~ s@\%2f@/@ig;
    $sourceurl =~ s@\%7e@~@ig;

but /usr/sbin/updxlrator only modifies with the middle one.
    $sourceurl =~ s@\%2f@/@ig;

The fix is to make /usr/sbin/updxlrator include all three entries.
Comment 1 jluth 2014-04-04 13:19:43 UTC 
This has been fixed in the next (unreleased) version for the sister project IPCop.

The author wrote:
>> I have packaged a pre-release:
>> http://blockouttraffic.de/files/ipcop-updatexlrator-2.2.9.tar.gz
Comment 2 Stefan Schantl 2014-05-10 17:53:46 UTC 

*** This bug has been marked as a duplicate of bug 10344 ***