Bug 10254 - Vendor icon "updxl-src-unknown.gif" are used, regardless of presence in image-dir
Summary: Vendor icon "updxl-src-unknown.gif" are used, regardless of presence in image...
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all Linux
: - Unknown - Minor Usability
Assignee: Bernhard Bitsch
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-27 13:48 UTC by Jörn-Ingo Weigert
Modified: 2015-04-21 17:11 UTC (History)
4 users (show)

See Also:


Attachments
Patch-file for updxlrator.cgi (3.45 KB, application/octet-stream)
2012-10-27 13:48 UTC, Jörn-Ingo Weigert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jörn-Ingo Weigert 2012-10-27 13:48:53 UTC
Created attachment 88 [details]
Patch-file for updxlrator.cgi

When a file is not in the updatecache or outdated, while the update process the image /srv/web/ipfire/html/images/updxl-src-unknown.gif is used, regardless the right image is present or not.

Cause of error: 
checking the presence in the wrong path of vendor image in /srv/web/ipfire/cgi-bin/updxlrator.cgi.
(/home/html/... instead of /srv/web/...)

Bugfix: 

- adding a variable (webhome) to change the webroot in future
- using of this variable to correct the error
- optimizing the logic to check for presence of vendor image instead of adding if-loop (if Avira ... if Microsoft etc ...)

Kind regards,

nightshift
Comment 1 Stefan Schantl 2013-03-01 19:44:38 UTC
Hello Jörn-Ingo,

please commit the patch to your IPFire 2 repository so we easily can pick and merge it into the IPFire 2 main repository.
Comment 2 Jörn-Ingo Weigert 2013-03-02 22:51:52 UTC
Bug fixed & tested, please merge, fix is in my repository


Changed old updxl-src-windows.gif to new one
Added new updxl-src-microsoft.gif, 

because $vendorid will now be used for searching appropriate updxl-src-<vendor>.gif and source vendor is defined as "mircrosoft" instead of "windows".

jiweigert
Comment 3 Bernhard Bitsch 2015-04-07 11:42:14 UTC
Patch is applied in current version ( core update 88 ).
Icons are existent in current version.

Image directory will be corrected in my "update accelerator revisited".