Bug 10022 - Unable to restore the status of an outgoing firewall rule
Summary: Unable to restore the status of an outgoing firewall rule
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: unspecified Unspecified
: - Unknown - - Unknown -
Assignee: Michael Tremer
QA Contact:
Depends on:
Reported: 2012-02-08 21:47 UTC by Mathias Schneuwly
Modified: 2012-03-06 22:09 UTC (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Schneuwly 2012-02-08 21:47:23 UTC
The current solution is unable to restore the state of an outgoing firewall rule. That means, if I edit a disabled outgoing firewall rule, the "enable" tick is always checked.

I found the bug in line 634 in the file "outgoingfw.cgi" and created a patch.
Comment 1 Mathias Schneuwly 2012-02-08 21:49:55 UTC
I'm getting always an error while attaching the patch file...

The file would look like this:
--- outgoingfw.cgi	2012-02-08 21:33:21.000000000 +0100
+++ outgoingfw.cgi	2012-02-08 21:31:39.000000000 +0100
@@ -631,7 +631,7 @@
 sub addrule
 	&Header::openbox('100%', 'center', $Lang::tr{'Add Rule'});
-	if ($outfwsettings{'EDIT'} eq 'no') { $selected{'ENABLED'} = 'checked'; }
+	if ($outfwsettings{'ENABLED'} eq 'on') { $selected{'ENABLED'} = 'checked'; }
 	$selected{'TIME_FROM'}{$outfwsettings{'TIME_FROM'}} = "selected='selected'";
 	$selected{'TIME_TO'}{$outfwsettings{'TIME_TO'}} = "selected='selected'";
 print <<END
Comment 2 Michael Tremer 2012-02-10 11:12:49 UTC
Thanks for reporting this issue.
Comment 3 Michael Tremer 2012-02-10 11:13:55 UTC
The patch was applied to the development tree and will be shipped with the next core update. Please check back if the fix actually works when a testing version of this core update becomes available.

Comment 4 Michael Tremer 2012-02-20 19:50:27 UTC
The Core Update has been pushed to the testing tree. Please test.
Comment 5 Mathias Schneuwly 2012-02-20 21:12:44 UTC
Core: 57-testing

Tested and confirmed! Works as expected... This problem is solved.
Comment 6 Michael Tremer 2012-03-06 22:09:07 UTC
The core update is released, so this bug can be closed.