| Summary: | Backup fails | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Bernhard Bitsch <bbitsch> |
| Component: | --- | Assignee: | Adolf Belka <adolf.belka> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Major Usability | ||
| Priority: | - Unknown - | CC: | adolf.belka, horace.michael, jon.murphy, michael.tremer |
| Version: | 2 | ||
| Hardware: | unspecified | ||
| OS: | Unspecified | ||
Cool, are you able to send a patch for this change? new link to Community posts: https://community.ipfire.org/t/add-on-backup-issue-relate-to-webgui-backup-restore/13300/1 Hi @Bernhard, Will you be supplying a patch for this or would it help if I picked it up? (In reply to Adolf Belka from comment #4) > Hi @Bernhard, > > Will you be supplying a patch for this or would it help if I picked it up? Hi @Adolf, it would help, if you pick it up. Thx in advance. Patch submitted https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/thread/J5XORX3ZY2JTLGLR5X7LWI6UHN2MZBQ6/ https://patchwork.ipfire.org/project/ipfire/list/?series=4661 Patch has been merged into CU191. Tested out on my vm testbed with CU191 Testing using a fresh install of bacula with the default bacula-fd.conf file. I then did an addon restore from bacula.ipf backed up from another vm testbed system. The restore ended up with the correct backup file restored so the fix patch is verified to be working. |
In a community post appeared the problem, that after new install the backup config of a addon could not be restored. Looking into the sources of backup.cgi, backupctrl and backup.pl I found the issue. In backup.pl the restore is done by - if a backup file is in /tmp, move it to /var/ipfire/backup/addons/backup - extract the backup file in /var/.... The test of existence in backup.pl ( line 288) is done by if [ -d "/tmp/${name}.ipf" ]; then which should be if [ -f "/tmp/${name}.ipf" ]; then