Bug 12496

Summary: WUI firewallhits Graph Wrong Average for NewNotSYN
Product: IPFire Reporter: Charles Brown <cab_77573>
Component: ---Assignee: Michael Tremer <michael.tremer>
Status: CLOSED FIXED QA Contact:
Severity: Aesthetic Issue    
Priority: Will affect all users CC: cab_77573, michael.tremer, peter.mueller
Version: 2   
Hardware: unspecified   
OS: Unspecified   
Attachments: https://ipfire:444/cgi-bin/netother.cgi
Zoomed out for a little more perspective
Min greater than Max

Description Charles Brown 2020-10-10 20:13:10 UTC
In the WUI, On Network (others) → firewallhits Graph on the NewNotSYN row, the value in the Average column shows zero even when min and max on that row have values greater than zero.

https://community.ipfire.org/t/newnotsyn-firewallhits-average/3389
Comment 1 Michael Tremer 2020-10-11 11:15:06 UTC
Could you please post the graph that shows the error?
Comment 2 Charles Brown 2020-10-11 15:23:03 UTC
Created attachment 784 [details]
https://ipfire:444/cgi-bin/netother.cgi
Comment 3 Charles Brown 2020-10-11 15:31:51 UTC
Created attachment 785 [details]
Zoomed out for a little more perspective
Comment 4 Michael Tremer 2020-10-12 10:30:20 UTC
The values were just mixed up:

https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=79131c6e47e535452625028477101ec59203e476

You can download the graphs.pl file and copy it to /var/ipfire/graphs.pl to test and confirm this fix.
Comment 5 Charles Brown 2020-10-12 10:45:05 UTC
Looks good, thanks.
Comment 8 Charles Brown 2020-11-20 19:02:58 UTC
Created attachment 805 [details]
Min greater than Max

I updated to 152 but I am seeing weird values in the tables -- should I expect "mBps" values in in min while max has "kBps" values?
Comment 9 Michael Tremer 2020-11-20 19:04:51 UTC
Yes this is correct. It is not "MBps" (as in mega), but milli as in millilitre.

rrdtool (which generates the graphs) is made for scientific stuff but it is very useless to use millibits/s. Statistically it makes sense.