Bug 11986

Summary: suricata: Rename IDS to IPS
Product: IPFire Reporter: Michael Tremer <michael.tremer>
Component: ---Assignee: Stefan Schantl <stefan.schantl>
Status: CLOSED FIXED QA Contact:
Severity: Aesthetic Issue    
Priority: - Unknown -    
Version: 2   
Hardware: unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 11801    

Description Michael Tremer 2019-02-01 11:23:56 UTC 
Everywhere where IDS is mentioned it should be IPS/Intrusion Prevention System.

Please use "Intrusion-Prevention-System" in German.

Also rename "Activate IDS" to "Enable IDS".
Comment 2 Michael Tremer 2019-02-05 12:56:14 UTC 
(In reply to Stefan Schantl from comment #1)
> https://git.ipfire.org/?p=people/stevee/ipfire-2.x.git;a=commit;
> h=cc9057c0148cddb231be85caa4c38d4cf721f0c3

You cannot really do this here.

The word order might be different and that cannot be changed by a translator. This is already kind of wrong for German, but you save it by going into the imperative which is not what we should be doing. Instead it should be like this:

English: Enable Intrusion Prevention System

German should be: Intrusion-Prevention-System aktivieren

You also might have that the case of the noun changes here.

So this has to be one string to give the translators the freedom they need.
Comment 3 Stefan Schantl 2019-02-05 13:18:49 UTC 
Thanks for the hint.

I've reworked the section now and use a single translation string as you suggested.

https://git.ipfire.org/?p=people/stevee/ipfire-2.x.git;a=commit;h=9e9b477d7c4fbad483f6307cf63bf475dd79141b
Comment 4 Michael Tremer 2019-02-05 13:20:16 UTC 
Your &nbsp is missing a ;
Comment 6 Stefan Schantl 2019-02-06 12:47:31 UTC 
All issues are fixed now, so I'm going to close this bug again.

Feel free to re-open if any new issues occur or I missed something.
Comment 7 Michael Tremer 2019-02-06 14:58:01 UTC 
The patches looked good. Did you check the log section, too?