| Summary: | Captive Portal: no way to remove an uploaded logo | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Daniel Weismüller <daniel.weismueller> |
| Component: | --- | Assignee: | Alexander Marx <alexander.marx> |
| Status: | CLOSED FIXED | QA Contact: | Michael Tremer <michael.tremer> |
| Severity: | Minor Usability | ||
| Priority: | - Unknown - | CC: | michael.tremer, peter.mueller |
| Version: | 2 | Keywords: | NewFeature |
| Hardware: | unspecified | ||
| OS: | Unspecified | ||
|
Description
Daniel Weismüller
2017-10-16 10:16:35 UTC
Ok. checked and confirmed Will work on this Well seems someone changed the code. In my original version the logo is shown on the config page. Can someone tell me why that was changed? Was there a special reason for that? As far as I remember I have never seen the logo being on the config page. I changed code and I may have removed it by accident, but I do not remember that it has ever been there. Yes. the function was edited and i had code for checking the dimensions and type of the logo. It makes sense to display it in the config page. I would recode the function and add a "Delete" Button for removing the Logo if that is ok for you. For this ticket, please just add the button. Added a button. Please test Has this patch been merged? I cannot find it on git.ipfire.org. :-/ If yes, I assume this can be closed as FIXED. Assuming this is fixed. If it is not, please reopen. Looking forward to more commit IDs reported in fixed bug in future lives... :-) Thank you. |