Bug 10504

Summary: UpdateXLRator keeps redownloading the same file if + or ~ in the URL
Product: IPFire Reporter: jluth
Component: ---Assignee: jluth
Status: CLOSED FIXED QA Contact:
Severity: Minor Usability    
Priority: - Unknown - CC: michael.tremer, stefan.schantl
Version: 2   
Hardware: all   
OS: All   
Bug Depends on:    
Bug Blocks: 11558    

Description jluth 2014-04-04 13:12:06 UTC
A bug in /usr/sbin/updxlrator keeps downloading the same file (especially noticeable with Ubuntu kernels) if there is a "+" or "~" in the URL.

That's because /var/ipfire/updatexlrator/bin/download modifies the sourceurl with these regexs:
    $sourceurl =~ s@\%2b@+@ig;
    $sourceurl =~ s@\%2f@/@ig;
    $sourceurl =~ s@\%7e@~@ig;

but /usr/sbin/updxlrator only modifies with the middle one.
    $sourceurl =~ s@\%2f@/@ig;

The fix is to make /usr/sbin/updxlrator include all three entries.
Comment 1 jluth 2014-04-04 13:19:43 UTC
This has been fixed in the next (unreleased) version for the sister project IPCop.

The author wrote:
>> I have packaged a pre-release:
>> http://blockouttraffic.de/files/ipcop-updatexlrator-2.2.9.tar.gz
Comment 2 Stefan Schantl 2014-05-10 17:53:46 UTC

*** This bug has been marked as a duplicate of bug 10344 ***