| Summary: | UpdateXLRator keeps redownloading the same file if + or ~ in the URL | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | jluth |
| Component: | --- | Assignee: | jluth |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Minor Usability | ||
| Priority: | - Unknown - | CC: | michael.tremer, stefan.schantl |
| Version: | 2 | ||
| Hardware: | all | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 11558 | ||
This has been fixed in the next (unreleased) version for the sister project IPCop.
The author wrote:
>> I have packaged a pre-release:
>> http://blockouttraffic.de/files/ipcop-updatexlrator-2.2.9.tar.gz
*** This bug has been marked as a duplicate of bug 10344 *** fix coming in c118 with patch https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=39c0b5b3bcd9d4cf57437d1988df834a1800c66c |
A bug in /usr/sbin/updxlrator keeps downloading the same file (especially noticeable with Ubuntu kernels) if there is a "+" or "~" in the URL. That's because /var/ipfire/updatexlrator/bin/download modifies the sourceurl with these regexs: $sourceurl =~ s@\%2b@+@ig; $sourceurl =~ s@\%2f@/@ig; $sourceurl =~ s@\%7e@~@ig; but /usr/sbin/updxlrator only modifies with the middle one. $sourceurl =~ s@\%2f@/@ig; The fix is to make /usr/sbin/updxlrator include all three entries.