| Summary: | updxlrator breaks on url with special characters inside | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Nico Prenzel <nico.prenzel> |
| Component: | --- | Assignee: | Assigned to nobody - feel free to grab it and work on it <nobody> |
| Status: | ASSIGNED --- | QA Contact: | |
| Severity: | Balancing | ||
| Priority: | - Unknown - | CC: | arne.fitzenreiter, bbitsch, gr786, jiweigert, jluth, michael.tremer, peter.mueller, stefan.schantl, zdroyer |
| Version: | 2 | ||
| Hardware: | all | ||
| OS: | Linux | ||
| Attachments: |
fix
patch to fix bug 10504 log showing how the proposed patch affects updxlrator |
||
|
Description
Nico Prenzel
2013-03-29 19:43:09 UTC
There seems to be additional positions still to fix to correct the problem. This fix you mentioned didn't work here. Please check your patch Kind regards, Ingo Weigert *** Bug 10504 has been marked as a duplicate of this bug. *** Created attachment 275 [details] patch to fix bug 10504 Created attachment 276 [details]
log showing how the proposed patch affects updxlrator
After three attempts which redownloaded the entire file each time, I applied the proposed patch and then updxlrator recognized that the file was cached locally.
This patch specifically fixes the bug reported in 10504, which was marked as a duplicate.
The problem with spaces in file names will be solved with my rewrite. Another "special" character that break Update Accelerator is $, eg: http://liveupdate.symantecliveupdate.com/ngc$20norton$20g2$20safe$20web$20statistics_1.0_symalllanguages_livetri.zip *** Bug 11588 has been marked as a duplicate of this bug. *** There is a thread in forum which faces the same problem. I'll supply a resolution soon. You guys need to follow the list since this bug has already been fixed here: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=39c0b5b3bcd9d4cf57437d1988df834a1800c66c Sorry, did not see that. Nevertheless this patch perhaps fixes some problems only. Space is a special character also, which can produce issues when inside a file name. Outstanding is still the use of $ in a filename. + and ~ were fixed long ago and \ is currently under review in bug 12252 |