| Summary: | Vendor icon "updxl-src-unknown.gif" are used, regardless of presence in image-dir | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Jörn-Ingo Weigert <jiweigert> |
| Component: | --- | Assignee: | Bernhard Bitsch <bbitsch> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Minor Usability | ||
| Priority: | - Unknown - | CC: | arne.fitzenreiter, bbitsch, michael.tremer, stefan.schantl |
| Version: | 2 | ||
| Hardware: | all | ||
| OS: | Linux | ||
| Attachments: | Patch-file for updxlrator.cgi | ||
Hello Jörn-Ingo, please commit the patch to your IPFire 2 repository so we easily can pick and merge it into the IPFire 2 main repository. Bug fixed & tested, please merge, fix is in my repository Changed old updxl-src-windows.gif to new one Added new updxl-src-microsoft.gif, because $vendorid will now be used for searching appropriate updxl-src-<vendor>.gif and source vendor is defined as "mircrosoft" instead of "windows". jiweigert Patch is applied in current version ( core update 88 ). Icons are existent in current version. Image directory will be corrected in my "update accelerator revisited". |
Created attachment 88 [details] Patch-file for updxlrator.cgi When a file is not in the updatecache or outdated, while the update process the image /srv/web/ipfire/html/images/updxl-src-unknown.gif is used, regardless the right image is present or not. Cause of error: checking the presence in the wrong path of vendor image in /srv/web/ipfire/cgi-bin/updxlrator.cgi. (/home/html/... instead of /srv/web/...) Bugfix: - adding a variable (webhome) to change the webroot in future - using of this variable to correct the error - optimizing the logic to check for presence of vendor image instead of adding if-loop (if Avira ... if Microsoft etc ...) Kind regards, nightshift