Bug 11307 - OpenSSL error 256 on adding a roadwarrior connection
Summary: OpenSSL error 256 on adding a roadwarrior connection
Status: CLOSED FIXED
Alias: None
Product: IPFire
Classification: Unclassified
Component: --- (show other bugs)
Version: 2
Hardware: all All
: Will only affect a few users Minor Usability
Assignee: Erik Kapfer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-24 16:54 UTC by Larsen
Modified: 2019-05-11 10:15 UTC (History)
3 users (show)

See Also:


Attachments
Check if RW host name is already set (679 bytes, patch)
2017-06-22 14:56 UTC, Erik Kapfer
Details
Check for Roadwarrior if certificate name is already set (686 bytes, patch)
2017-06-23 10:40 UTC, Erik Kapfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Larsen 2017-03-24 16:54:26 UTC
When you try to add a new roadwarrior connection and use a name for the certificate that is already in use (which you might not know about), you will get this error on saving: "OpenSSL hat einen Fehler verursacht: 256" (don't know what would have been shown in English).

In "/var/log/httpd/error_log" you can see:
failed to update database
TXT_DB error number 2

Proposed solution:
IPFire should check if the name is already in use and then present a meaningful error message or if this is not possible to check, at least check the log for said error message and inform the user what might possibly be the cause.
Comment 1 Erik Kapfer 2017-06-22 14:56:07 UTC
Created attachment 526 [details]
Check if RW host name is already set

Have made a patch for Roadwarriors which should prevent that a client name will be used two times so no OpenSSL warning 256 comes up and a useful error message should be delivered.

Greetings,

Erik
Comment 2 Larsen 2017-06-23 09:48:20 UTC
Patch didn't work for me. Still the same error messages.

Do you check for the name of the connection ("Name:") or for the name of the certificate ("Voller Name oder System-Hostname des Benutzers")?

The first one is already checked. Problem exists for the second one.
Comment 3 Erik Kapfer 2017-06-23 10:40:22 UTC
Created attachment 527 [details]
Check for Roadwarrior if certificate name is already set

I see, thanks for checking this. 
Have attached another patch ( ovpn_check_for_RW_cert_name.patch ) which should solve this.

Erik
Comment 4 Larsen 2017-06-23 12:08:39 UTC
Works fine now, thx!
Comment 5 Erik Kapfer 2017-06-23 16:01:02 UTC
Good to hear,
thanks for the feedback.

Greetings,

Erik
Comment 6 Larsen 2017-08-22 12:17:57 UTC
@Erik: Is this patch already implemented in Core?
Ticket could be closed then, I guess.
Comment 7 Michael Tremer 2018-06-18 15:02:42 UTC
(In reply to Larsen from comment #6)
> @Erik: Is this patch already implemented in Core?
> Ticket could be closed then, I guess.

No it isn't.

@Erik: Please submit the patch again or close this ticket if no longer relevant.
Comment 8 Erik Kapfer 2018-06-18 17:35:37 UTC
Patch has been delivered --> https://patchwork.ipfire.org/patch/1820/ .

Best,

Erik
Comment 9 Michael Tremer 2018-06-18 17:53:08 UTC
Please set tickets to MODIFIED when a patch has been submitted.
Comment 10 Erik Kapfer 2018-06-18 19:49:16 UTC
OK, will do that. Thanks for reminding.

Best,

Erik
Comment 11 Peter Müller 2019-05-11 10:15:27 UTC
I assume this can be closed as FIXED.

If not, please reopen it. Thank you. :-)