Bug 14504

Summary: Geofeeds in remarks are only being found when spelled exactly "Geofeed https://..."
Product: Location Database Reporter: Michael Tremer <michael.tremer>
Component: liblocAssignee: Michael Tremer <michael.tremer>
Status: CLOSED FIXED QA Contact: Peter Müller <peter.mueller>
Severity: Minor Usability    
Priority: Will only affect a few users    
Version: unspecified   
Hardware: all   
OS: All   

Description Michael Tremer 2026-10-20 10:49:53 UTC
location-importer only finds a Geofeed in the remarks of an inetnum if it is spelled exactly "Geofeed https://...", but some are spelled "geofeed https://...", "Geofeed: https://..." or "geofeed: https://...". The pattern also takes everything until the end of the line, so that anything after the URL becomes part of it.

In the databases of 2026-10-19, that leaves out 24 inetnum objects of AFRINIC, 28 of LACNIC, and 25 of APNIC.
Comment 1 Michael Tremer 2026-10-20 10:53:25 UTC
https://git.ipfire.org/?p=location/libloc.git;a=commit;h=01e15653595c9cbe1921c1f1bfc674119db1f92a

Author: Michael Tremer <michael.tremer@ipfire.org>

importer: Find Geofeeds in remarks however they are being spelled

Some remarks say "geofeed https://...", "Geofeed: https://..." or
"geofeed: https://...", which have not been found. The URL now also
ends at the first space, so that nothing after it becomes part of it.

With the data of AFRINIC of 2026-10-19, this finds 24 more networks
with 6 more Geofeeds, and none less.

Fixes: #14504 - Geofeeds in remarks are only being found when spelled exactly "Geofeed https://..."
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Comment 2 Michael Tremer 2026-10-20 10:53:39 UTC
This has been implemented in the master branch of libloc (01e1565). With the data of AFRINIC of 2026-10-19, 24 more networks with 6 more Geofeeds are being found, and none less.

This will be in the database once the importer with this change has been running.
Comment 3 Michael Tremer 2026-10-20 10:53:41 UTC
http://git.ipfire.org/?p=location/libloc.git;a=commit;h=01e15653595c9cbe1921c1f1bfc674119db1f92a

Author: Michael Tremer <michael.tremer@ipfire.org>

importer: Find Geofeeds in remarks however they are being spelled

Some remarks say "geofeed https://...", "Geofeed: https://..." or
"geofeed: https://...", which have not been found. The URL now also
ends at the first space, so that nothing after it becomes part of it.

With the data of AFRINIC of 2026-10-19, this finds 24 more networks
with 6 more Geofeeds, and none less.

Fixes: #14504 - Geofeeds in remarks are only being found when spelled exactly "Geofeed https://..."
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Comment 4 Michael Tremer 2026-10-26 16:43:32 UTC
This has been fixed in libloc 0.9.20, which has just been tagged. Closing this as fixed.