Bug 13736

Summary: IPFire Backup includes makeqosscripts.pl and possibly other files which should not be backed up
Product: IPFire Reporter: Tim Zakharov <tim>
Component: ---Assignee: Adolf Belka <adolf.belka>
Status: CLOSED FIXED QA Contact:
Severity: Major Usability    
Priority: Will affect an average number of users CC: adolf.belka, himemsys36
Version: 2   
Hardware: x86_64   
OS: Unspecified   

Description Tim Zakharov 2024-08-04 10:34:24 UTC 
I recently backed up a Core Update 186 system, did a fresh install, and restored my backup.  The goal was to move QoS over to the current CAKE.  I viewed makeqosscripts.pl after the fresh install and it was set up for CAKE.  I viewed this file again after restoring my backup and this file was overwritten with my very old copy which has migrated through 10 years of backups and restores.

See this post in the IPFire Forums:
https://community.ipfire.org/t/celeron-j3160-capabilities-with-qos/11464/87?u=bloater99  

@Adolf Belka was helping me and determined that there are several files in var/ipfire/qos/* which probably should not be included in the backup, but are.

Because of this bug I am stuck with an old version of QoS unless I either install from scratch and rebuild the firewall from scratch, or edit my backup before restoring it as Adolf instructed in the linked post above.  For me, this is a Major Usability bug.
Comment 1 Adolf Belka 2024-08-05 21:10:59 UTC 
Discussed in August Developers conf call and I am picking up this bug to put a fix together, test it and submit a patch for it.
Comment 3 Adolf Belka 2025-03-07 10:06:16 UTC 
The patch has been merged into next.

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=ad4cc933457b0ad659e0c49ab56451d4b4b7c083
Comment 5 Adolf Belka 2025-03-26 15:21:32 UTC 
Have checked out the backup of qos with CU193 Testing. None of the programmatic .pl files are backed up anymore.

So with qos disabled the /var/ipfire/qos/bin directory has nothing saved in the backup anymore.

When qos is enabled and running then there is now a qos.sh file in that /bin/ directory and that is still backed up as that defines the settings that have been configured for the qos setup.

So the fix has been confirmed as working.

This would be good if it could also be confirmed by the original bug poster, @Tim.
Comment 6 himemsys36 2025-03-26 15:34:20 UTC 
(In reply to Adolf Belka from comment #5)
> Have checked out the backup of qos with CU193 Testing. None of the
> programmatic .pl files are backed up anymore.
> 
> So with qos disabled the /var/ipfire/qos/bin directory has nothing saved in
> the backup anymore.
> 
> When qos is enabled and running then there is now a qos.sh file in that
> /bin/ directory and that is still backed up as that defines the settings
> that have been configured for the qos setup.
> 
> So the fix has been confirmed as working.
> 
> This would be good if it could also be confirmed by the original bug poster,
> @Tim.

I hope over the coming weekend to upgrade to CU193 Testing so I can confirm.  Thank you, Adolf.