Bug 13656

Summary: Apache restart does not start after stop due to pid still in existence
Product: IPFire Reporter: Adolf Belka <adolf.belka>
Component: ---Assignee: Adolf Belka <adolf.belka>
Status: CLOSED FIXED QA Contact:
Severity: Major Usability    
Priority: - Unknown -    
Version: 2   
Hardware: all   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 13657    

Description Adolf Belka 2024-04-24 10:58:25 UTC 
Several users updating to Core Update 185 have had their WUI access freeze.

Despite the freeze the update has completed but Apache was not started.

The Core Update log showed

Stopping Apache daemon…
e[1Ae[0Ge[-8Ge[1;34m[e[1;32m OK e[1;34m]e[0;39m
Starting Apache daemon…
httpd (pid 2812) already running
e[1Ae[0Ge[-8Ge[1;34m[e[1;32m OK e[1;34m]e[0;39m

This shows that Apache was stopped and got an OK status but then the start was attempted straight away but the old pid was not yet completely removed hence the initscript thought apache was already running and did not start it.

This issue has been reported on and off by users over several Core Updates but became much more prevalent with Core Update 185.

The initscript was changed to its present form at Core Update 181 to deal with a problem of apache not being properly stopped and hence restarted when a glibc upgrade was carried out.
Comment 1 Adolf Belka 2024-04-24 10:59:37 UTC 
I will submit a patch to check in the stop section that the httpd.pid file is no longer present before finishing the stop section.
Comment 3 Adolf Belka 2024-04-24 16:02:24 UTC 
I have marked this bug as blocking for 13567 as this needs to be solved before the apache initscript is shipped and built into the appropriate Core Updates.
Comment 4 Adolf Belka 2024-04-24 16:04:17 UTC 
Sorry I made an error. This bug is blocking 13657 not 13567.

Apologies for noise
Comment 5 Adolf Belka 2024-04-29 19:47:52 UTC 
Modified patch has been submitted by @Michael.

https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=1724e5ac0ac4a139e9f7d574129f53a027197676

This has been merged into next
Comment 6 Adolf Belka 2024-05-10 19:46:34 UTC 
This has now been issued with CU186 Testing.
Comment 7 Adolf Belka 2024-05-10 20:11:50 UTC 
CU186 Testing has been issued.

https://www.ipfire.org/blog/ipfire-2-29-core-update-186-is-available-for-testing
Comment 8 Adolf Belka 2024-06-13 17:10:10 UTC 
Core Update 186 has been released

https://www.ipfire.org/blog/ipfire-2-29-core-update-186-released