Bug 13404

When creating a new OpenVPN connection with a client certificate, putting in a CN that already exists will fail to create the connection, but will create a certificate file and update index.txt in /var/ipfire/ovpn/certs.

Steps to reproduce:
1. Create a connection named abc. In the certificate part, put in abc for CN and abc for O. The file abc.p12 will be put in /var/ipfire/ovpn/certs, index.txt will be updated with the line

V bignumber smallnumber unknown /C=xx/O=abc/CN=abc

2. Create a connection called def. Put in abc for CN and def in O (different connection name, same CN, different O). The creation of the connection fails with the error “A connection with this common name already exists.”

/var/ipfire/ovpn/certs now also contains the file def.p12. index.txt contains the lines

V bignumber smallnumber unknown /C=xx/O=abc/CN=abc
V bignumber smallnumber unknown /C=xx/O=def/CN=abc

It seems to me if the connection is not created, the certificate file should not be created either and index.txt should not be updated with the new line.

As an aside (a different cosmetic bug perhaps?), the error message “A connection with this common name already exists.” is not very useful. CN is labeled "User's full name or system hostname:" in IPFire, the words "common name" don't appear anywhere. I thought "common name" was the connection name at first.