Bug 13150

Summary: QOS
Product: IPFire Reporter: Oto Drabek <drabek>
Component: ---Assignee: Michael Tremer <michael.tremer>
Status: CLOSED FIXED QA Contact:
Severity: Aesthetic Issue    
Priority: Will affect an average number of users CC: adolf.belka, emmanuel.bourgeois, hico.s, michael.tremer, rodneyp
Version: 2   
Hardware: x86_64   
OS: Linux   
URL: https://community.ipfire.org/t/qos-graphs-not-working-in-175/9885/6
Attachments: Screenshot of QOS in CU174
Screenshot of QOS set up in CU175
Screenshot of QOS upgrades from CU174 to CU175
Screenshot of QOS upgrades from CU174 to CU175
Screenshot QOS graphs CU175 with fix
Screenshot QOS graphs CU175 with fix

Description Oto Drabek 2023-06-14 06:06:05 UTC
After updating to 175, the QOS graphs do not work
( previously fine )

----
I have already tried this procedure, unfortunately it did not help
I tried again now (doesn’t help)
qos does not create log files in /var/log/rrd

*****************************************
Adolf Belka
bonnietwin

1
11h
If @otadr had the graphs working in CU174 and they are giving the error message in CU175 then that looks like there is a bug present.

To confirm, I started QOS up on CU175 and after 30 mins I still had the following status
+++++++++++++
Then I installed CU174 on a vm system and started QOS the same way and virtually straight away I had a graph, even if there was no content on it yet.
++++++++++++++
So in CU175 there are many files missing which in CU174 are created straight away when QOS is started.
******************
Comment 1 Adolf Belka 2023-06-14 11:27:42 UTC
Created attachment 1191 [details]
Screenshot of QOS in CU174

This topic was raised in the community thread
https://community.ipfire.org/t/qos-graphs-not-working-in-175/9885

I have been able to reproduce some of the effects seen but not all.

This attachment shows the QOS screen after starting it with the Preset option in CU174.

The graphs were shown immediately and after a short while data was seen.
Comment 2 Adolf Belka 2023-06-14 11:31:59 UTC
Bugs with IPFire2.x should always have the Component set to ---

The component values are only to be used for Bugs with IPFire3.x
Comment 3 Adolf Belka 2023-06-14 11:37:01 UTC
Created attachment 1192 [details]
Screenshot of QOS set up in CU175

This attachment shows the QOS screen after starting it with the Preset option in CU175

There is only shown the Error message.

The files in /var/log/rrd are

ls -hal /var/log/rrd/
total 1.7M
drwxr-xr-x  4 root root 4.0K Jun 14 12:47 .
drwxr-xr-x 19 root root 4.0K Jun 14 12:42 ..
-rw-r--r--  1 root root 745K Jun 14 12:49 class_1-1_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:49 class_2-1_imq0.rrd
drwxr-xr-x  3 root root 4.0K Jul 27  2020 collectd
-rw-r--r--  1 root root  29K Jun 12 13:50 hddshutdown-md127.rrd
-rw-r--r--  1 root root  29K Jun 12 13:50 hddshutdown-sda.rrd
-rw-r--r--  1 root root  29K Jun 12 13:50 hddshutdown-sdb.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-md127.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-sda.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-sdb.rrd
drwxr-xr-x  2 root root 4.0K Apr  8 14:05 wio


This compares with the situation for the CU174 setup.
ls -hal /var/log/rrd/
total 9.7M
drwxr-xr-x  4 root root 4.0K Jun 14 12:03 .
drwxr-xr-x 17 root root 4.0K Jun 14 12:01 ..
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-101_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-102_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-103_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-104_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-110_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-120_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_1-1_red0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-1_imq0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-200_imq0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-203_imq0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-204_imq0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-210_imq0.rrd
-rw-r--r--  1 root root 745K Jun 14 12:05 class_2-220_imq0.rrd
drwxr-xr-x  3 root root 4.0K Jul 27  2020 collectd
-rw-r--r--  1 root root  29K Jun 14 12:05 hddshutdown-md127.rrd
-rw-r--r--  1 root root  29K Jun 14 12:05 hddshutdown-sda.rrd
-rw-r--r--  1 root root  29K Jun 14 12:05 hddshutdown-sdb.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-md127.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-sda.rrd
-rw-r--r--  1 root root  29K Dec 30 12:45 hddtemp-sdb.rrd
drwxr-xr-x  2 root root 4.0K Apr  8 14:05 wio

The situation of a fresh QOS setup not working with CU175 was reported in the forum by Earl Texter
@animosity022
Comment 4 Adolf Belka 2023-06-14 11:45:03 UTC
Created attachment 1193 [details]
Screenshot of QOS upgrades from CU174 to CU175

The reporter of this bug had the issue of a working QOS with CU174 and after updating to CU175 the graphs had stopped being shown and there was the error page.

This screen shot shows my results of the QOS page after upgrading from CU174 to CU175 and doing a reboot.

The graph has stayed in place and is still showing new data.

So I have not been able to reproduce the effect reported by Oto Drabek, although I have been able to reproduce the effect reported by Earl Texter.

All the tests above I have carried out on my vm testbed system.

I also tried setting up QOS with the Preset option on my physical IPFire after it had been upgraded to CU175 and again had the same issue as shown in attachment 1192 [details]
Comment 5 Manu B 2023-06-16 07:50:21 UTC
I have the exact same issue as reported by Oto.

With 174 QOS graph was fine.
After update to 175, the graph was empty (Y axis set to 1 byte/seconds and no data).

After few days without data, I followed the procedure described in the wiki (https://wiki.ipfire.org/installation/hardware-change), now I get error message for both req0 and imq0 graphs even after waiting over 30mn or a reboot.

I have two other sites running 174 that I did not update yet for which QOS graphs are working properly.
Comment 6 Hico 2023-06-18 15:29:54 UTC
Since the update from 174 → 175,
the old rrd-files are all there and have a current date and time stamp,
 but no new added content.
Comment 7 Hico 2023-06-18 15:38:25 UTC
Created attachment 1195 [details]
Screenshot of QOS upgrades from CU174 to CU175
Comment 8 Michael Tremer 2023-06-22 15:52:53 UTC
> https://patchwork.ipfire.org/project/ipfire/patch/20230622155115.1741-1-michael.tremer@ipfire.org/

This should fix it.

QoS is working fine. It is just that the graphs are not being parsed correctly.
Comment 9 Manu B 2023-06-22 18:48:21 UTC
Created attachment 1196 [details]
Screenshot QOS graphs CU175 with fix
Comment 10 Manu B 2023-06-22 18:48:56 UTC
Confirmed, the fix works.

Thanks!
Comment 11 Michael Tremer 2023-06-23 17:06:03 UTC
(In reply to Manu B from comment #10)
> Confirmed, the fix works.
> 
> Thanks!

Thank you for verifying :)
Comment 12 Hico 2023-06-24 12:47:33 UTC
Created attachment 1197 [details]
Screenshot QOS graphs CU175 with fix

Jupp, fix works fine.

Thanks.
Comment 13 Rodney Peters 2023-07-03 01:31:38 UTC
QOS graphs are working in CU 176 Testing.
Comment 14 Adolf Belka 2023-07-03 10:11:42 UTC
Core Update 176 Testing has been released

https://blog.ipfire.org/post/ipfire-2-27-core-update-176-is-available-for-testing
Comment 15 Adolf Belka 2023-07-03 10:12:24 UTC
(In reply to Rodney Peters from comment #13)
> QOS graphs are working in CU 176 Testing.

This verifies that the fix works.
Comment 16 Adolf Belka 2023-07-12 09:41:16 UTC
Core Update 176 released

https://blog.ipfire.org/post/ipfire-2-27-core-update-176-released