Summary: | Online status wrongly calculated for OpenVPN certs with underscore in their common name. | ||
---|---|---|---|
Product: | IPFire | Reporter: | Thorsten Schöning <tschoening> |
Component: | openvpn | Assignee: | Assigned to nobody - feel free to grab it and work on it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | |
Severity: | Major Usability | ||
Priority: | Will affect most users | CC: | michael.tremer |
Version: | 3 | ||
Hardware: | all | ||
OS: | Unspecified |
Description
Thorsten Schöning
2021-06-16 14:58:33 UTC
This is a not a bug because the web UI does not allow you creating connections with certain characters. (In reply to Michael Tremer from comment #1) > This is a not a bug because the web UI does not allow you creating > connections with certain characters. It's not about connection names, but the common name which DOES allow underscores to be used. So you have "ovpnconfig" containing the COMMON NAME "ams_tschoening" and the status log of OVPN containing the COMMON NAME "ams_tschoening" as well. then the codes goes and changes the COMMON NAME of the status log to "ams tschoening" and tries to map that to COMMON NAME "ams_tschoening" in ovpnconfig. It's pretty likely a bug... Okay, do you have a proposed change? (In reply to Michael Tremer from comment #3) > Okay, do you have a proposed change? Find the reason why "_" is changed to " " and if it's a valid one, don't allow "_" in common names as this can't work then. I didn't find a reason looking at the history and couldn't think of any valid one, so I guess this change is a left-over which might simply be removed. It might be that past web-UIs didn't allow to generate common names with "_", but some users might used externally generated certs or on the shell or alike and this should increase compatibility with what the web-UI did or whatever. Though, mapping the common names of both sources 1:1 seems OK and safe to me. So I suggest simply removing the replacement. Everything else can't even be easily documented to users and stuff. |