Bug 12501

Summary: Exclude non-globally routable space from the database
Product: Location Database Reporter: Michael Tremer <michael.tremer>
Component: DatabaseAssignee: Peter Müller <peter.mueller>
Status: CLOSED FIXED QA Contact: Michael Tremer <michael.tremer>
Severity: Crash    
Priority: Will affect an average number of users    
Version: unspecified   
Hardware: unspecified   
OS: Unspecified   
See Also: https://bugzilla.ipfire.org/show_bug.cgi?id=12499

Description Michael Tremer 2020-10-14 10:40:21 UTC
The database currently lists 192.168.0.0/15 as "EU". I do not know where this is coming from since WHOIS does not show anything for this network.

Since the database is being structured as a tree, 192.168.0.0/16 which is part of RFC1918 is being shown as "EU" which is incorrect.

We need to have a way to add the RFC1918 networks to the database and mark them as "holes" in the data. We either return a network without a country and some "private" flag, or we simply do not return a network at all.

I have worked around this for the time being with this patch: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=c69c820025c21713cdb77eae3dd4fa61ca71b5fb
Comment 2 Peter Müller 2020-10-19 12:18:22 UTC
inetnum:        192.168.0.0 - 192.169.95.255
netname:        NON-RIPE-NCC-MANAGED-ADDRESS-BLOCK
descr:          IPv4 address block not managed by the RIPE NCC
remarks:        ------------------------------------------------------
remarks:
remarks:        For registration information,
remarks:        you can consult the following sources:
remarks:
remarks:        IANA
remarks:        http://www.iana.org/assignments/ipv4-address-space
remarks:        http://www.iana.org/assignments/iana-ipv4-special-registry
remarks:        http://www.iana.org/assignments/ipv4-recovered-address-space
remarks:
remarks:        AFRINIC (Africa)
remarks:        http://www.afrinic.net/ whois.afrinic.net
remarks:
remarks:        APNIC (Asia Pacific)
remarks:        http://www.apnic.net/ whois.apnic.net
remarks:
remarks:        ARIN (Northern America)
remarks:        http://www.arin.net/ whois.arin.net
remarks:
remarks:        LACNIC (Latin America and the Carribean)
remarks:        http://www.lacnic.net/ whois.lacnic.net
remarks:
remarks:        ------------------------------------------------------
country:        EU # Country is really world wide
admin-c:        DUMY-RIPE
tech-c:         DUMY-RIPE
status:         ALLOCATED UNSPECIFIED
mnt-by:         RIPE-NCC-HM-MNT
created:        2019-11-13T12:44:29Z
last-modified:  2019-11-13T12:44:29Z
source:         RIPE
remarks:        ****************************
remarks:        * THIS OBJECT IS MODIFIED
remarks:        * Please note that all data that is generally regarded as personal
remarks:        * data has been removed from this object.
remarks:        * To view the original object, please query the RIPE Database at:
remarks:        * http://www.ripe.net/whois
remarks:        ****************************
Comment 3 Peter Müller 2020-10-19 12:18:40 UTC
I am working on a fix to exclude those networks...
Comment 4 Peter Müller 2020-10-21 09:14:20 UTC
Fix is done and seems to work fine on location02.
Comment 7 Peter Müller 2020-12-20 11:35:38 UTC
This is fixed in libloc 0.9.5, which is running in production for several weeks by now.