Bug 11413

Summary: WUI hardcoded attr in firewall.cgi causes multiple radio 'checked'
Product: IPFire Reporter: Diego Augusto Molina <ipfire>
Component: ---Assignee: Assigned to nobody - feel free to grab it and work on it <nobody>
Status: CLOSED DEFERRED QA Contact:
Severity: Minor Usability    
Priority: - Unknown - CC: peter.mueller
Version: 2   
Hardware: all   
OS: All   
See Also: https://bugzilla.ipfire.org/show_bug.cgi?id=11695
Attachments: Patch

Description Diego Augusto Molina 2017-07-02 01:52:54 UTC
Created attachment 528 [details]
Patch

Steps to reproduce:

1) Go to 'Firewall' -> 'New rule'.
2) Fill in the form for the new rule and check a radio button for "Source", "Destination" or "-Preset-" (under "Protocol") other than the first radio of the group.
3) Commit the form.
4) Edit the rule that has just been created.

Expected result:

The radio button checked in step 2 will be the only one in its group to have the "checked" attribute.

Actual result:

The radio button checked in step 2 will have the "checked" attribute *BUT* the first radio of the group will also have it.
Comment 1 Peter Müller 2017-11-08 17:36:27 UTC
Please send the patch to the mailing list. Tank you. :-)
Comment 2 Peter Müller 2018-02-06 20:38:56 UTC
Sorry if I was too short here. :-)

The complete procedure about how to send in patches, and everyting else, is described here: https://wiki.ipfire.org/devel/submit-patches
Comment 3 Peter Müller 2019-10-13 10:52:49 UTC
Closing this as there was no reply. If it is still valid and someone interested to work on this, please reopen.