Bug 10846

Summary:	Field marked as "can be empty" when it cannot
Product:	IPFire	Reporter:	Larsen <larsen007>
Component:	---	Assignee:	Assigned to nobody - feel free to grab it and work on it <nobody>
Status:	CLOSED FIXED	QA Contact:
Severity:	Balancing
Priority:	- Unknown -	CC:	michael.tremer
Version:	2
Hardware:	unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	10847

Description Larsen 2015-05-13 12:59:36 UTC

When you create a new roadwarrior connection, there is the field "Name der Organisation" which is marked with a star and thus should be possible to be left empty.

Though, on saving you will get the error "Ungültige Eingabe für Organisation". So, the star should be removed.

btw: Every other webpage or service I know uses the other way "items with a star need to be filled in". Care to change this behaviour?

Comment 1 Michael Tremer 2015-05-13 15:43:16 UTC

(In reply to Larsen from comment #0)
> When you create a new roadwarrior connection, there is the field "Name der
> Organisation" which is marked with a star and thus should be possible to be
> left empty.
> 
> Though, on saving you will get the error "Ungültige Eingabe für
> Organisation". So, the star should be removed.

This is not fully intentional. It should be possible to leave the field empty although it usually makes sense to copy that information from the CA certificate.

I guess I can confirm that this is a bug then.

> btw: Every other webpage or service I know uses the other way "items with a
> star need to be filled in". Care to change this behaviour?

I also regard this as a bug now. When the web interface has been written the default on the web was to declare the optional input fields optional. Nowadays it is the other way round and people do not check the bottom of the page any more to find out what the star is supposed to tell. They just assume that this is a required field. I do care to change this. This would just need to be changed on the entire web user interface at once for consistency. Would you like doing that? (This should be an extra bug report though)

Comment 2 Larsen 2015-05-13 16:16:50 UTC

(In reply to Michael Tremer from comment #1)
> assume that this is a required field. I do care to change this. This would
> just need to be changed on the entire web user interface at once for
> consistency. Would you like doing that? (This should be an extra bug report
> though)

Yes, I would.

http://wiki.ipfire.org/en/development/git is still valid?
Can you please provide me with a starting point, i.e. one small file where I can find the star?

IIRC, as an bugzilla admin you could clone this bug to separate it, can´t you?

Comment 3 Michael Tremer 2015-05-14 16:44:17 UTC

A better starting point would be this: http://wiki.ipfire.org/devel/start

If you clone the repository, you will find all the CGI files in html/cgi-bin which you will need to change to that the star is shown for the right inputs. The star image is somewhere in html/html/...

Comment 4 Larsen 2015-10-10 23:26:34 UTC

Uploaded a patch:
http://patchwork.ipfire.org/patch/100/

Comment 5 Larsen 2015-12-22 16:30:55 UTC

Has already been released with Core Update 94