| Summary: | Oddities with Certificate Names | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Tom Rymes <tomvend> |
| Component: | --- | Assignee: | Adolf Belka <adolf.belka> |
| Status: | ON_QA --- | QA Contact: | |
| Severity: | Balancing | ||
| Priority: | Will affect an average number of users | CC: | adolf.belka, michael.tremer, peter.mueller |
| Version: | 2 | Keywords: | GoodFirstBug |
| Hardware: | all | ||
| OS: | All | ||
| See Also: | https://bugzilla.ipfire.org/show_bug.cgi?id=11594 | ||
| Bug Depends on: | |||
| Bug Blocks: | 11618 | ||
|
Description
Tom Rymes
2014-08-19 16:54:48 UTC
OK, not much of a start, but I did figure out the solution to #1. The English translation file located at /var/ipfire/langs/en.pl contains the offending strings, and I would suggest changing line 1967 from 'root certificate' => 'Root certificate', to 'root certificate' => 'Root Certificate', Is there somewhere that I should place this, or is here enough? attach a modified file? I will try to figure out the portion of vpnmain.cgi that controls the form validation for #2, but that's way beyond my skillset. This bug has been closed as fixed but there were two parts to it and only the first part was fixed. Therefore I have re-opened it and will submit a patch to fix the second part. I came across this one when looking at a similar open bug related to OpenVPN where this bug related to IPSec was referenced. Patch submitted into dev mailing list and patchwork. https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/thread/ROQIIEWTI3BHTN6CF2CLSE243BQ3GXRS/ https://patchwork.ipfire.org/project/ipfire/list/?series=4653 Change tested out on my vm system and confirmed to allow CA Names with spaces to be uploaded. The patch set has been reverted https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=754451021b7d6fa6aa812b1ac2f017fb118bd383 https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=17ad30b9e2aaca5b90df98ceee9ac68a9c68e238 as the placing of quotation marks around the $_[0] I have learnt is bad code as it results in a potential vulnerability situation. I have been given some guidance on an alternative approach and I am working on that and will re-submit the patch set as a v2 version once I have got the new fix working. Updated patch set submitted to dev mailing list and patchwork. https://lists.ipfire.org/hyperkitty/list/development@lists.ipfire.org/thread/JW5LP2W3UAHZVN75TW4W5VLXNBC4CO2G/ https://patchwork.ipfire.org/project/ipfire/list/?series=4774 This v2 patch set version uses the &General::system_output function suggested by @Michael. v3 version of the patch set has been submitted as the previous v2 version clashed with another bug patch update of the same file. https://lists.ipfire.org/development/20250306113221.6990-1-adolf.belka@ipfire.org/T/#t https://patchwork.ipfire.org/project/ipfire/list/?series=4775 v3 patch set has been merged into next. https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=f82c1bd187d7a3a1001db4bb42b3f989f9c223f7 https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=bfd3c3f0c20be976dab670162d4891c192433f72 |