Bug 10526

Summary:	Firewall GUI displays wrong Source IP Adress in 2.15
Product:	IPFire	Reporter:	Marcus <marcus.steck>
Component:	---	Assignee:	Alexander Marx <alexander.marx>
Status:	CLOSED FIXED	QA Contact:
Severity:	Balancing
Priority:	- Unknown -	CC:	michael.tremer, stefan.schantl
Version:	2
Hardware:	x86_64
OS:	Unspecified
Bug Depends on:
Bug Blocks:	10486

Description Marcus 2014-04-17 05:05:56 UTC

Hello There,

thank you very much for deploying this nice firewall rules GUI on 2.15
its a cool improvment.

i've found a bug concerning this GUI. after saving the rule and reopen. it displays the default IP Adress (BLUE) at the source field. (NAT DNAT or SNAT)

If i change the source ip adress to green again it displays blue again on reopen the mask.

Next:
on the new source ip adress field i can't find the entry (RED 0.0.0.0). 

regards

Marcus

Comment 1 Alexander Marx 2014-04-17 13:58:41 UTC

Hi

I tried to reproduce this error but had no luck.
WHen i create a rule with either SNAT or DNAT, and select an interface, this interface is selected on reopening the rule.

Please provide your network config and what settings you had for your rule.
 
The second part is true. The entry RED  is missing.

Comment 2 Alexander Marx 2014-04-22 10:08:24 UTC

Part one of Bug is not reproduceable - Not a Bug.

Part two (missing red interface in SNAT dropdown) is fixed with:

http://git.ipfire.org/?p=people/amarx/ipfire-2.x.git;a=blobdiff;f=html/cgi-bin/firewall.cgi;h=8b5696a018d035099201c1f6566d6b05ffd8ce67;hp=53c7c1c1fe094150845007a95bb3e2d81d9560c2;hb=a65d1d6bda831eb013dffb4889edbc0837acb90a;hpb=d6cc816f9353f47bb83dafe876f19d943a7a3828

Comment 3 Michael Tremer 2014-04-22 10:45:24 UTC

I can confirm that the SNAT radio button is not checked and that the IP address that has been selected in the dropdown menu is reset (part one). So that needs to be fixed.

I don't really see why you would want to use RED for SNAT. By default, all traffic that goes to the Internet is translated to the RED default address, so no rule is needed for that.

Unfortunately, you made some conversation in private, which would have been better to have here.

Comment 4 Alexander Marx 2014-04-22 12:18:01 UTC

I edited the last commit.
http://git.ipfire.org/?p=people/amarx/ipfire-2.x.git;a=commit;h=bb458b193b4ddeca31cf8fa8b0b5bd000c6ed9ea

RED interface should NOT be displayed in the snat dropdown menu.
But now the right ALIAS is selcted when editing a rule.