| Summary: | Severall small improvements for the backiso script | ||
|---|---|---|---|
| Product: | IPFire | Reporter: | Timo Eissler <morlix> |
| Component: | --- | Assignee: | Arne.F <arne.fitzenreiter> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Balancing | ||
| Priority: | - Unknown - | CC: | arne.fitzenreiter, michael.tremer, morlix, stefan.schantl |
| Version: | 2 | ||
| Hardware: | all | ||
| OS: | Linux | ||
| Attachments: |
small improvements for backupiso script.
severall improvements for creating a backup iso (old indentation) |
||
The patch looks very good, but could you please stick to the old indentation and re-upload it? Created attachment 105 [details]
severall improvements for creating a backup iso (old indentation)
severall improvements for creating a backup iso
- do not create a backup if md5 sum mismatch
- update syntax for newer bash versions
- remove md5 sum and downloaded iso
Thank you. Arne will take care of it now. - remove md5 sum and downloaded iso Md5 is ok but I think it is a bad idea to remove the source iso. I don't want download it at every backup again. ah sorry i didn't thought about that It's not your fault. The original script also download it always because it also not check if the file exists. I have changed this in git. Fix released with IPFire 2.13. |
Created attachment 73 [details] small improvements for backupiso script. Hello, today i made a backup of my ipfire and looked at the backupiso script because i wanted to know why there are 2 isos created for one backup. After looking over the code i decided to improve it a little bit in my opinion. I made the following changes: - do not create a backup if md5 sum mismatch - update syntax for newer bash versions - switched from tab or x whitespace for indenting to 3 whitespaces - remove md5 sum and downloaded iso I will be happy if you or anyone else also finds these changes good and integrate it into ipfire. kind regards, Timo